Changeset 47198 for trunk/src/wp-admin/includes/update-core.php

Timestamp:

02/06/2020 06:31:22 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/includes/update-core.php (modified) (2 diffs)

trunk/src/wp-admin/includes/update-core.php

@@ -937 +937 @@
 
     $wp_filesystem->chmod( $versions_file, FS_CHMOD_FILE );
-    require( WP_CONTENT_DIR . '/upgrade/version-current.php' );
+    require WP_CONTENT_DIR . '/upgrade/version-current.php';
     $wp_filesystem->delete( $versions_file );
 
@@ -1434 +1434 @@
 
     // Include admin-footer.php and exit.
-    include( ABSPATH . 'wp-admin/admin-footer.php' );
+    require_once ABSPATH . 'wp-admin/admin-footer.php';
     exit();
 }