Changeset 47198 for trunk/src/wp-admin/includes/update.php

Timestamp:

02/06/2020 06:31:22 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/includes/update.php (modified) (2 diffs)

trunk/src/wp-admin/includes/update.php

@@ -91 +91 @@
         }
 
-        include_once( ABSPATH . 'wp-admin/includes/class-wp-upgrader.php' );
+        require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
 
         $auto_update = false;
@@ -725 +725 @@
 function maintenance_nag() {
         // Include an unmodified $wp_version.
-        include( ABSPATH . WPINC . '/version.php' );
+        require ABSPATH . WPINC . '/version.php';
         global $upgrading;
         $nag = isset( $upgrading );