Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/update.php

    r47122 r47198  
    9191    }
    9292
    93     include_once( ABSPATH . 'wp-admin/includes/class-wp-upgrader.php' );
     93    require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
    9494
    9595    $auto_update = false;
     
    725725function maintenance_nag() {
    726726    // Include an unmodified $wp_version.
    727     include( ABSPATH . WPINC . '/version.php' );
     727    require ABSPATH . WPINC . '/version.php';
    728728    global $upgrading;
    729729    $nag = isset( $upgrading );
Note: See TracChangeset for help on using the changeset viewer.