Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/index.php

    r46586 r47198  
    77 */
    88
    9 if ( file_exists( dirname( __FILE__ ) . '/../wp-includes/js/dist/edit-post.js' ) ) {
    10     require_once dirname( __FILE__ ) . '/_index.php';
     9if ( file_exists( __DIR__ . '/../wp-includes/js/dist/edit-post.js' ) ) {
     10    require_once __DIR__ . '/_index.php';
    1111    return;
    1212}
    1313
    14 require_once dirname( dirname( __FILE__ ) ) . '/index.php';
     14require_once dirname( __DIR__ ) . '/index.php';
Note: See TracChangeset for help on using the changeset viewer.