Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (5 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/load-styles.php

    r47122 r47198  
    1010/** Set ABSPATH for execution */
    1111if ( ! defined( 'ABSPATH' ) ) {
    12     define( 'ABSPATH', dirname( dirname( __FILE__ ) ) . '/' );
     12    define( 'ABSPATH', dirname( __DIR__ ) . '/' );
    1313}
    1414
    1515define( 'WPINC', 'wp-includes' );
    1616
    17 require( ABSPATH . 'wp-admin/includes/noop.php' );
    18 require( ABSPATH . WPINC . '/script-loader.php' );
    19 require( ABSPATH . WPINC . '/version.php' );
     17require ABSPATH . 'wp-admin/includes/noop.php';
     18require ABSPATH . WPINC . '/script-loader.php';
     19require ABSPATH . WPINC . '/version.php';
    2020
    2121$protocol = $_SERVER['SERVER_PROTOCOL'];
Note: See TracChangeset for help on using the changeset viewer.