Changeset 47198 for trunk/src/wp-admin/network/sites.php

Timestamp:

02/06/2020 06:31:22 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/network/sites.php (modified) (7 diffs)

trunk/src/wp-admin/network/sites.php

@@ -9 +9 @@
 
 /** Load WordPress Administration Bootstrap */
-require_once( dirname( __FILE__ ) . '/admin.php' );
+require_once __DIR__ . '/admin.php';
 
 if ( ! current_user_can( 'manage_sites' ) ) {
@@ -109 +109 @@
                 $site_address = untrailingslashit( $site_details->domain . $site_details->path );
 
-                require_once( ABSPATH . 'wp-admin/admin-header.php' );
+                require_once ABSPATH . 'wp-admin/admin-header.php';
                 ?>
                         <div class="wrap">
@@ -123 +123 @@
                         </div>
                 <?php
-                require_once( ABSPATH . 'wp-admin/admin-footer.php' );
+                require_once ABSPATH . 'wp-admin/admin-footer.php';
                 exit();
         } elseif ( array_key_exists( $_GET['action'], $manage_actions ) ) {
@@ -185 +185 @@
                                                 switch ( $doaction ) {
                                                         case 'delete':
-                                                                require_once( ABSPATH . 'wp-admin/admin-header.php' );
+                                                                require_once ABSPATH . 'wp-admin/admin-header.php';
                                                                 ?>
                                                                 <div class="wrap">
@@ -210 +210 @@
                                                                 </div>
                                                                 <?php
-                                                                require_once( ABSPATH . 'wp-admin/admin-footer.php' );
+                                                                require_once ABSPATH . 'wp-admin/admin-footer.php';
                                                                 exit();
                                                         break;
@@ -355 +355 @@
 $wp_list_table->prepare_items();
 
-require_once( ABSPATH . 'wp-admin/admin-header.php' );
+require_once ABSPATH . 'wp-admin/admin-header.php';
 ?>
 
@@ -389 +389 @@
 <?php
 
-require_once( ABSPATH . 'wp-admin/admin-footer.php' ); ?>
+require_once ABSPATH . 'wp-admin/admin-footer.php'; ?>