Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (5 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/network/sites.php

    r46384 r47198  
    99
    1010/** Load WordPress Administration Bootstrap */
    11 require_once( dirname( __FILE__ ) . '/admin.php' );
     11require_once __DIR__ . '/admin.php';
    1212
    1313if ( ! current_user_can( 'manage_sites' ) ) {
     
    109109        $site_address = untrailingslashit( $site_details->domain . $site_details->path );
    110110
    111         require_once( ABSPATH . 'wp-admin/admin-header.php' );
     111        require_once ABSPATH . 'wp-admin/admin-header.php';
    112112        ?>
    113113            <div class="wrap">
     
    123123            </div>
    124124        <?php
    125         require_once( ABSPATH . 'wp-admin/admin-footer.php' );
     125        require_once ABSPATH . 'wp-admin/admin-footer.php';
    126126        exit();
    127127    } elseif ( array_key_exists( $_GET['action'], $manage_actions ) ) {
     
    185185                        switch ( $doaction ) {
    186186                            case 'delete':
    187                                 require_once( ABSPATH . 'wp-admin/admin-header.php' );
     187                                require_once ABSPATH . 'wp-admin/admin-header.php';
    188188                                ?>
    189189                                <div class="wrap">
     
    210210                                </div>
    211211                                <?php
    212                                 require_once( ABSPATH . 'wp-admin/admin-footer.php' );
     212                                require_once ABSPATH . 'wp-admin/admin-footer.php';
    213213                                exit();
    214214                            break;
     
    355355$wp_list_table->prepare_items();
    356356
    357 require_once( ABSPATH . 'wp-admin/admin-header.php' );
     357require_once ABSPATH . 'wp-admin/admin-header.php';
    358358?>
    359359
     
    389389<?php
    390390
    391 require_once( ABSPATH . 'wp-admin/admin-footer.php' ); ?>
     391require_once ABSPATH . 'wp-admin/admin-footer.php'; ?>
Note: See TracChangeset for help on using the changeset viewer.