Changeset 47198 for trunk/src/wp-admin/network/themes.php

Timestamp:

02/06/2020 06:31:22 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/network/themes.php (modified) (8 diffs)

trunk/src/wp-admin/network/themes.php

@@ -9 +9 @@
 
 /** Load WordPress Administration Bootstrap */
-require_once( dirname( __FILE__ ) . '/admin.php' );
+require_once __DIR__ . '/admin.php';
 
 if ( ! current_user_can( 'manage_network_themes' ) ) {
@@ -77 +77 @@
             $parent_file = 'themes.php';
 
-            require_once( ABSPATH . 'wp-admin/admin-header.php' );
+            require_once ABSPATH . 'wp-admin/admin-header.php';
 
             echo '<div class="wrap">';
@@ -87 +87 @@
             echo "<iframe src='$url' style='width: 100%; height:100%; min-height:850px;'></iframe>";
             echo '</div>';
-            require_once( ABSPATH . 'wp-admin/admin-footer.php' );
+            require_once ABSPATH . 'wp-admin/admin-footer.php';
             exit;
         case 'delete-selected':
@@ -115 +115 @@
             }
 
-            include( ABSPATH . 'wp-admin/update.php' );
+            require ABSPATH . 'wp-admin/update.php';
 
             $parent_file = 'themes.php';
@@ -121 +121 @@
             if ( ! isset( $_REQUEST['verify-delete'] ) ) {
                 wp_enqueue_script( 'jquery' );
-                require_once( ABSPATH . 'wp-admin/admin-header.php' );
+                require_once ABSPATH . 'wp-admin/admin-header.php';
                 $themes_to_delete = count( $themes );
                 ?>
@@ -176 +176 @@
             </div>
                 <?php
-                require_once( ABSPATH . 'wp-admin/admin-footer.php' );
+                require_once ABSPATH . 'wp-admin/admin-footer.php';
                 exit;
             } // End if verify-delete.
@@ -262 +262 @@
 wp_enqueue_script( 'theme-preview' );
 
-require_once( ABSPATH . 'wp-admin/admin-header.php' );
+require_once ABSPATH . 'wp-admin/admin-header.php';
 
 ?>
@@ -344 +344 @@
 wp_print_update_row_templates();
 
-include( ABSPATH . 'wp-admin/admin-footer.php' );
+require_once ABSPATH . 'wp-admin/admin-footer.php';