WordPress.org

Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (8 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/network/upgrade.php

    r45932 r47198  
    99
    1010/** Load WordPress Administration Bootstrap */
    11 require_once( dirname( __FILE__ ) . '/admin.php' );
     11require_once __DIR__ . '/admin.php';
    1212
    13 require_once( ABSPATH . WPINC . '/http.php' );
     13require_once ABSPATH . WPINC . '/http.php';
    1414
    1515$title       = __( 'Upgrade Network' );
     
    3333);
    3434
    35 require_once( ABSPATH . 'wp-admin/admin-header.php' );
     35require_once ABSPATH . 'wp-admin/admin-header.php';
    3636
    3737if ( ! current_user_can( 'upgrade_network' ) ) {
     
    153153</div>
    154154
    155 <?php include( ABSPATH . 'wp-admin/admin-footer.php' ); ?>
     155<?php require_once ABSPATH . 'wp-admin/admin-footer.php'; ?>
Note: See TracChangeset for help on using the changeset viewer.