Changeset 47198 for trunk/src/wp-admin/options.php

Timestamp:

02/06/2020 06:31:22 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/options.php (modified) (4 diffs)

trunk/src/wp-admin/options.php

@@ -17 +17 @@
 
 /** WordPress Administration Bootstrap */
-require_once( dirname( __FILE__ ) . '/admin.php' );
+require_once __DIR__ . '/admin.php';
 
 $title       = __( 'Settings' );
@@ -250 +250 @@
         // Handle translation installation.
         if ( ! empty( $_POST['WPLANG'] ) && current_user_can( 'install_languages' ) ) {
-            require_once( ABSPATH . 'wp-admin/includes/translation-install.php' );
+            require_once ABSPATH . 'wp-admin/includes/translation-install.php';
 
             if ( wp_can_install_language_pack() ) {
@@ -317 +317 @@
 }
 
-include( ABSPATH . 'wp-admin/admin-header.php' ); ?>
+require_once ABSPATH . 'wp-admin/admin-header.php'; ?>
 
 <div class="wrap">
@@ -377 +377 @@
 
 <?php
-include( ABSPATH . 'wp-admin/admin-footer.php' );
+require_once ABSPATH . 'wp-admin/admin-footer.php';