Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/options.php

    r47159 r47198  
    1717
    1818/** WordPress Administration Bootstrap */
    19 require_once( dirname( __FILE__ ) . '/admin.php' );
     19require_once __DIR__ . '/admin.php';
    2020
    2121$title       = __( 'Settings' );
     
    250250        // Handle translation installation.
    251251        if ( ! empty( $_POST['WPLANG'] ) && current_user_can( 'install_languages' ) ) {
    252             require_once( ABSPATH . 'wp-admin/includes/translation-install.php' );
     252            require_once ABSPATH . 'wp-admin/includes/translation-install.php';
    253253
    254254            if ( wp_can_install_language_pack() ) {
     
    317317}
    318318
    319 include( ABSPATH . 'wp-admin/admin-header.php' ); ?>
     319require_once ABSPATH . 'wp-admin/admin-header.php'; ?>
    320320
    321321<div class="wrap">
     
    377377
    378378<?php
    379 include( ABSPATH . 'wp-admin/admin-footer.php' );
     379require_once ABSPATH . 'wp-admin/admin-footer.php';
Note: See TracChangeset for help on using the changeset viewer.