Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/plugin-editor.php

    r47122 r47198  
    88
    99/** WordPress Administration Bootstrap */
    10 require_once( dirname( __FILE__ ) . '/admin.php' );
     10require_once __DIR__ . '/admin.php';
    1111
    1212if ( is_multisite() && ! is_network_admin() ) {
     
    2525
    2626if ( empty( $plugins ) ) {
    27     include( ABSPATH . 'wp-admin/admin-header.php' );
     27    require_once ABSPATH . 'wp-admin/admin-header.php';
    2828    ?>
    2929    <div class="wrap">
     
    3232    </div>
    3333    <?php
    34     include( ABSPATH . 'wp-admin/admin-footer.php' );
     34    require_once ABSPATH . 'wp-admin/admin-footer.php';
    3535    exit;
    3636}
     
    152152wp_add_inline_script( 'wp-theme-plugin-editor', sprintf( 'wp.themePluginEditor.themeOrPlugin = "plugin";' ) );
    153153
    154 require_once( ABSPATH . 'wp-admin/admin-header.php' );
     154require_once ABSPATH . 'wp-admin/admin-header.php';
    155155
    156156update_recently_edited( WP_PLUGIN_DIR . '/' . $file );
     
    337337endif; // Editor warning notice.
    338338
    339 include( ABSPATH . 'wp-admin/admin-footer.php' );
     339require_once ABSPATH . 'wp-admin/admin-footer.php';
Note: See TracChangeset for help on using the changeset viewer.