Changeset 47198 for trunk/src/wp-admin/plugins.php

Timestamp:

02/06/2020 06:31:22 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/plugins.php (modified) (8 diffs)

trunk/src/wp-admin/plugins.php

@@ -8 +8 @@
 
 /** WordPress Administration Bootstrap */
-require_once( dirname( __FILE__ ) . '/admin.php' );
+require_once __DIR__ . '/admin.php';
 
 if ( ! current_user_can( 'activate_plugins' ) ) {
@@ -144 +144 @@
 
             wp_enqueue_script( 'updates' );
-            require_once( ABSPATH . 'wp-admin/admin-header.php' );
+            require_once ABSPATH . 'wp-admin/admin-header.php';
 
             echo '<div class="wrap">';
@@ -154 +154 @@
             echo "<iframe src='$url' style='width: 100%; height:100%; min-height:850px;'></iframe>";
             echo '</div>';
-            require_once( ABSPATH . 'wp-admin/admin-footer.php' );
+            require_once ABSPATH . 'wp-admin/admin-footer.php';
             exit;
 
@@ -278 +278 @@
             }
 
-            include( ABSPATH . 'wp-admin/update.php' );
+            require ABSPATH . 'wp-admin/update.php';
 
             $parent_file = 'plugins.php';
@@ -284 +284 @@
             if ( ! isset( $_REQUEST['verify-delete'] ) ) {
                 wp_enqueue_script( 'jquery' );
-                require_once( ABSPATH . 'wp-admin/admin-header.php' );
+                require_once ABSPATH . 'wp-admin/admin-header.php';
                 ?>
             <div class="wrap">
@@ -374 +374 @@
             </div>
                 <?php
-                require_once( ABSPATH . 'wp-admin/admin-footer.php' );
+                require_once ABSPATH . 'wp-admin/admin-footer.php';
                 exit;
             } else {
@@ -484 +484 @@
 $parent_file = 'plugins.php';
 
-require_once( ABSPATH . 'wp-admin/admin-header.php' );
+require_once ABSPATH . 'wp-admin/admin-header.php';
 
 $invalid = validate_active_plugins();
@@ -646 +646 @@
 wp_print_update_row_templates();
 
-include( ABSPATH . 'wp-admin/admin-footer.php' );
+require_once ABSPATH . 'wp-admin/admin-footer.php';