Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/plugins.php

    r47122 r47198  
    88
    99/** WordPress Administration Bootstrap */
    10 require_once( dirname( __FILE__ ) . '/admin.php' );
     10require_once __DIR__ . '/admin.php';
    1111
    1212if ( ! current_user_can( 'activate_plugins' ) ) {
     
    144144
    145145            wp_enqueue_script( 'updates' );
    146             require_once( ABSPATH . 'wp-admin/admin-header.php' );
     146            require_once ABSPATH . 'wp-admin/admin-header.php';
    147147
    148148            echo '<div class="wrap">';
     
    154154            echo "<iframe src='$url' style='width: 100%; height:100%; min-height:850px;'></iframe>";
    155155            echo '</div>';
    156             require_once( ABSPATH . 'wp-admin/admin-footer.php' );
     156            require_once ABSPATH . 'wp-admin/admin-footer.php';
    157157            exit;
    158158
     
    278278            }
    279279
    280             include( ABSPATH . 'wp-admin/update.php' );
     280            require ABSPATH . 'wp-admin/update.php';
    281281
    282282            $parent_file = 'plugins.php';
     
    284284            if ( ! isset( $_REQUEST['verify-delete'] ) ) {
    285285                wp_enqueue_script( 'jquery' );
    286                 require_once( ABSPATH . 'wp-admin/admin-header.php' );
     286                require_once ABSPATH . 'wp-admin/admin-header.php';
    287287                ?>
    288288            <div class="wrap">
     
    374374            </div>
    375375                <?php
    376                 require_once( ABSPATH . 'wp-admin/admin-footer.php' );
     376                require_once ABSPATH . 'wp-admin/admin-footer.php';
    377377                exit;
    378378            } else {
     
    484484$parent_file = 'plugins.php';
    485485
    486 require_once( ABSPATH . 'wp-admin/admin-header.php' );
     486require_once ABSPATH . 'wp-admin/admin-header.php';
    487487
    488488$invalid = validate_active_plugins();
     
    646646wp_print_update_row_templates();
    647647
    648 include( ABSPATH . 'wp-admin/admin-footer.php' );
     648require_once ABSPATH . 'wp-admin/admin-footer.php';
Note: See TracChangeset for help on using the changeset viewer.