Changeset 47198 for trunk/src/wp-admin/site-health.php

Timestamp:

02/06/2020 06:31:22 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/site-health.php (modified) (4 diffs)

trunk/src/wp-admin/site-health.php

@@ -8 +8 @@
 
 if ( isset( $_GET['tab'] ) && 'debug' === $_GET['tab'] ) {
-    require_once( dirname( __FILE__ ) . '/site-health-info.php' );
+    require_once __DIR__ . '/site-health-info.php';
     return;
 }
 
 /** WordPress Administration Bootstrap */
-require_once( dirname( __FILE__ ) . '/admin.php' );
+require_once __DIR__ . '/admin.php';
 
 $title = __( 'Site Health Status' );
@@ -25 +25 @@
 
 if ( ! class_exists( 'WP_Site_Health' ) ) {
-    require_once( ABSPATH . 'wp-admin/includes/class-wp-site-health.php' );
+    require_once ABSPATH . 'wp-admin/includes/class-wp-site-health.php';
 }
 
@@ -33 +33 @@
 $health_check_site_status->check_wp_version_check_exists();
 
-require_once( ABSPATH . 'wp-admin/admin-header.php' );
+require_once ABSPATH . 'wp-admin/admin-header.php';
 ?>
 <div class="health-check-header">
@@ -158 +158 @@
 
 <?php
-include( ABSPATH . 'wp-admin/admin-footer.php' );
+require_once ABSPATH . 'wp-admin/admin-footer.php';