WordPress.org

Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (8 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/theme-install.php

    r47122 r47198  
    88
    99/** WordPress Administration Bootstrap */
    10 require_once( dirname( __FILE__ ) . '/admin.php' );
    11 require( ABSPATH . 'wp-admin/includes/theme-install.php' );
     10require_once __DIR__ . '/admin.php';
     11require ABSPATH . 'wp-admin/includes/theme-install.php';
    1212
    1313wp_reset_vars( array( 'tab' ) );
     
    132132);
    133133
    134 include( ABSPATH . 'wp-admin/admin-header.php' );
     134require_once ABSPATH . 'wp-admin/admin-header.php';
    135135
    136136?>
     
    373373wp_print_admin_notice_templates();
    374374
    375 include( ABSPATH . 'wp-admin/admin-footer.php' );
     375require_once ABSPATH . 'wp-admin/admin-footer.php';
Note: See TracChangeset for help on using the changeset viewer.