Changeset 47198 for trunk/src/wp-admin/upload.php

Timestamp:

02/06/2020 06:31:22 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/upload.php (modified) (5 diffs)

trunk/src/wp-admin/upload.php

@@ -8 +8 @@
 
 /** WordPress Administration Bootstrap */
-require_once( dirname( __FILE__ ) . '/admin.php' );
+require_once __DIR__ . '/admin.php';
 
 if ( ! current_user_can( 'upload_files' ) ) {
@@ -80 +80 @@
     $parent_file = 'upload.php';
 
-    require_once( ABSPATH . 'wp-admin/admin-header.php' );
+    require_once ABSPATH . 'wp-admin/admin-header.php';
     ?>
     <div class="wrap" id="wp-media-grid" data-search="<?php _admin_search_query(); ?>">
@@ -108 +108 @@
     </div>
     <?php
-    include( ABSPATH . 'wp-admin/admin-footer.php' );
+    require_once ABSPATH . 'wp-admin/admin-footer.php';
     exit;
 }
@@ -262 +262 @@
 );
 
-require_once( ABSPATH . 'wp-admin/admin-header.php' );
+require_once ABSPATH . 'wp-admin/admin-header.php';
 ?>
 
@@ -379 +379 @@
 
 <?php
-include( ABSPATH . 'wp-admin/admin-footer.php' );
+require_once ABSPATH . 'wp-admin/admin-footer.php';