Changeset 47198 for trunk/src/wp-admin/users.php

Timestamp:

02/06/2020 06:31:22 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-admin/users.php (modified) (5 diffs)

trunk/src/wp-admin/users.php

@@ -9 +9 @@
 
 /** WordPress Administration Bootstrap */
-require_once( dirname( __FILE__ ) . '/admin.php' );
+require_once __DIR__ . '/admin.php';
 
 if ( ! current_user_can( 'list_users' ) ) {
@@ -265 +265 @@
         }
 
-        include( ABSPATH . 'wp-admin/admin-header.php' );
+        require_once ABSPATH . 'wp-admin/admin-header.php';
         ?>
     <form method="post" name="updateusers" id="updateusers">
@@ -407 +407 @@
         }
 
-        include( ABSPATH . 'wp-admin/admin-header.php' );
+        require_once ABSPATH . 'wp-admin/admin-header.php';
         ?>
     <form method="post" name="updateusers" id="updateusers">
@@ -476 +476 @@
         }
 
-        include( ABSPATH . 'wp-admin/admin-header.php' );
+        require_once ABSPATH . 'wp-admin/admin-header.php';
 
         $messages = array();
@@ -598 +598 @@
 } // End of the $doaction switch.
 
-include( ABSPATH . 'wp-admin/admin-footer.php' );
+require_once ABSPATH . 'wp-admin/admin-footer.php';