Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (4 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/blocks/rss.php

    r47051 r47198  
    2121
    2222    if ( ! $rss->get_item_quantity() ) {
     23        // PHP 5.2 compatibility. See: http://simplepie.org/wiki/faq/i_m_getting_memory_leaks.
     24        $rss->__destruct();
     25        unset( $rss );
     26
    2327        return '<div class="components-placeholder"><div class="notice notice-error">' . __( 'An error has occurred, which probably means the feed is down. Try again later.' ) . '</div></div>';
    2428    }
     
    9397    }
    9498
    95     return "<ul class='{$class}'>{$list_items}</ul>";
     99    $list_items_markup = "<ul class='{$class}'>{$list_items}</ul>";
     100
     101    // PHP 5.2 compatibility. See: http://simplepie.org/wiki/faq/i_m_getting_memory_leaks.
     102    $rss->__destruct();
     103    unset( $rss );
     104
     105    return $list_items_markup;
    96106}
    97107
Note: See TracChangeset for help on using the changeset viewer.