Changeset 47198 for trunk/src/wp-includes/class-wp-editor.php

Timestamp:

02/06/2020 06:31:22 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-includes/class-wp-editor.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-editor.php

@@ -219 +219 @@
 
                 if ( ! function_exists( 'media_buttons' ) ) {
-                    include( ABSPATH . 'wp-admin/includes/media.php' );
+                    require ABSPATH . 'wp-admin/includes/media.php';
                 }
 
@@ -490 +490 @@
                             foreach ( $mce_external_languages as $name => $path ) {
                                 if ( @is_file( $path ) && @is_readable( $path ) ) {
-                                    include_once( $path );
+                                    include_once $path;
                                     $ext_plugins   .= $strings . "\n";
                                     $loaded_langs[] = $name;