Changeset 47198 for trunk/src/wp-includes/load.php

Timestamp:

02/06/2020 06:31:22 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-includes/load.php (modified) (7 diffs)

trunk/src/wp-includes/load.php

@@ -140 +140 @@
 
         if ( ! extension_loaded( 'mysql' ) && ! extension_loaded( 'mysqli' ) && ! extension_loaded( 'mysqlnd' ) && ! file_exists( WP_CONTENT_DIR . '/db.php' ) ) {
-                require_once( ABSPATH . WPINC . '/functions.php' );
+                require_once ABSPATH . WPINC . '/functions.php';
                 wp_load_translations_early();
                 $args = array(
@@ -193 +193 @@
         global $upgrading;
 
-        include( ABSPATH . '.maintenance' );
+        require ABSPATH . '.maintenance';
         // If the $upgrading timestamp is older than 10 minutes, don't die.
         if ( ( time() - $upgrading ) >= 600 ) {
@@ -217 +217 @@
 
         if ( file_exists( WP_CONTENT_DIR . '/maintenance.php' ) ) {
-                require_once( WP_CONTENT_DIR . '/maintenance.php' );
+                require_once WP_CONTENT_DIR . '/maintenance.php';
                 die();
         }
 
-        require_once( ABSPATH . WPINC . '/functions.php' );
+        require_once ABSPATH . WPINC . '/functions.php';
         wp_load_translations_early();
 
@@ -410 +410 @@
         global $wpdb;
 
-        require_once( ABSPATH . WPINC . '/wp-db.php' );
+        require_once ABSPATH . WPINC . '/wp-db.php';
         if ( file_exists( WP_CONTENT_DIR . '/db.php' ) ) {
-                require_once( WP_CONTENT_DIR . '/db.php' );
+                require_once WP_CONTENT_DIR . '/db.php';
         }
 
@@ -545 +545 @@
                          */
                         if ( file_exists( WP_CONTENT_DIR . '/object-cache.php' ) ) {
-                                require_once( WP_CONTENT_DIR . '/object-cache.php' );
+                                require_once WP_CONTENT_DIR . '/object-cache.php';
                                 if ( function_exists( 'wp_cache_init' ) ) {
                                         wp_using_ext_object_cache( true );
@@ -567 +567 @@
 
         if ( ! wp_using_ext_object_cache() ) {
-                require_once( ABSPATH . WPINC . '/cache.php' );
+                require_once ABSPATH . WPINC . '/cache.php';
         }
 
@@ -607 +607 @@
                 nocache_headers();
 
-                require( ABSPATH . WPINC . '/kses.php' );
-                require( ABSPATH . WPINC . '/pluggable.php' );
+                require ABSPATH . WPINC . '/kses.php';
+                require ABSPATH . WPINC . '/pluggable.php';
 
                 $link = wp_guess_url() . '/wp-admin/install.php';