Changeset 47198 for trunk/src/wp-includes/theme.php

Timestamp:

02/06/2020 06:31:22 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/src/wp-includes/theme.php (modified) (3 diffs)

trunk/src/wp-includes/theme.php

@@ -2639 +2639 @@
 
                 if ( is_admin() ) {
-                        require_once( ABSPATH . 'wp-admin/includes/class-custom-image-header.php' );
+                        require_once ABSPATH . 'wp-admin/includes/class-custom-image-header.php';
                         $custom_image_header = new Custom_Image_Header( $args[0]['admin-head-callback'], $args[0]['admin-preview-callback'] );
                 }
@@ -2652 +2652 @@
 
                 if ( is_admin() ) {
-                        require_once( ABSPATH . 'wp-admin/includes/class-custom-background.php' );
+                        require_once ABSPATH . 'wp-admin/includes/class-custom-background.php';
                         $custom_background = new Custom_Background( $args[0]['admin-head-callback'], $args[0]['admin-preview-callback'] );
                 }
@@ -2898 +2898 @@
 function require_if_theme_supports( $feature, $include ) {
         if ( current_theme_supports( $feature ) ) {
-                require( $include );
+                require $include;
                 return true;
         }