Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (5 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/includes/factory.php

    r46586 r47198  
    11<?php
    22
    3 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-factory-for-thing.php' );
    4 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-factory-for-post.php' );
    5 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-factory-for-bookmark.php' );
    6 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-factory-for-attachment.php' );
    7 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-factory-for-user.php' );
    8 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-factory-for-comment.php' );
    9 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-factory-for-blog.php' );
    10 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-factory-for-network.php' );
    11 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-factory-for-term.php' );
    12 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-generator-sequence.php' );
    13 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-factory-callback-after-create.php' );
    14 require_once( dirname( __FILE__ ) . '/factory/class-wp-unittest-factory.php' );
     3require_once __DIR__ . '/factory/class-wp-unittest-factory-for-thing.php';
     4require_once __DIR__ . '/factory/class-wp-unittest-factory-for-post.php';
     5require_once __DIR__ . '/factory/class-wp-unittest-factory-for-bookmark.php';
     6require_once __DIR__ . '/factory/class-wp-unittest-factory-for-attachment.php';
     7require_once __DIR__ . '/factory/class-wp-unittest-factory-for-user.php';
     8require_once __DIR__ . '/factory/class-wp-unittest-factory-for-comment.php';
     9require_once __DIR__ . '/factory/class-wp-unittest-factory-for-blog.php';
     10require_once __DIR__ . '/factory/class-wp-unittest-factory-for-network.php';
     11require_once __DIR__ . '/factory/class-wp-unittest-factory-for-term.php';
     12require_once __DIR__ . '/factory/class-wp-unittest-generator-sequence.php';
     13require_once __DIR__ . '/factory/class-wp-unittest-factory-callback-after-create.php';
     14require_once __DIR__ . '/factory/class-wp-unittest-factory.php';
Note: See TracChangeset for help on using the changeset viewer.