Changeset 47198 for trunk/tests/phpunit/tests/ajax/MediaEdit.php

Timestamp:

02/06/2020 06:31:22 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/tests/phpunit/tests/ajax/MediaEdit.php (modified) (3 diffs)

trunk/tests/phpunit/tests/ajax/MediaEdit.php

@@ -3 +3 @@
  * Admin Ajax functions to be tested.
  */
-require_once( ABSPATH . 'wp-admin/includes/ajax-actions.php' );
+require_once ABSPATH . 'wp-admin/includes/ajax-actions.php';
 
 /**
@@ -28 +28 @@
      */
     public function testCropImageThumbnail() {
-        include_once( ABSPATH . 'wp-admin/includes/image-edit.php' );
+        require_once ABSPATH . 'wp-admin/includes/image-edit.php';
 
         $filename = DIR_TESTDATA . '/images/canola.jpg';
@@ -59 +59 @@
         define( 'IMAGE_EDIT_OVERWRITE', true );
 
-        include_once( ABSPATH . 'wp-admin/includes/image-edit.php' );
+        require_once ABSPATH . 'wp-admin/includes/image-edit.php';
 
         $filename = DIR_TESTDATA . '/images/canola.jpg';