WordPress.org

Make WordPress Core


Ignore:
Timestamp:
02/06/2020 06:31:22 AM (2 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

  • Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
  • Replacing include statements for several files with require_once, for consistency:
    • wp-admin/admin-header.php
    • wp-admin/admin-footer.php
    • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/image/functions.php

    r47122 r47198  
    1414        parent::setUp();
    1515
    16         require_once( ABSPATH . WPINC . '/class-wp-image-editor.php' );
    17         require_once( ABSPATH . WPINC . '/class-wp-image-editor-gd.php' );
    18         require_once( ABSPATH . WPINC . '/class-wp-image-editor-imagick.php' );
    19 
    20         include_once( DIR_TESTDATA . '/../includes/mock-image-editor.php' );
     16        require_once ABSPATH . WPINC . '/class-wp-image-editor.php';
     17        require_once ABSPATH . WPINC . '/class-wp-image-editor-gd.php';
     18        require_once ABSPATH . WPINC . '/class-wp-image-editor-imagick.php';
     19
     20        require_once DIR_TESTDATA . '/../includes/mock-image-editor.php';
    2121
    2222        // Ensure no legacy / failed tests detritus.
     
    134134        }
    135135
    136         include_once( ABSPATH . 'wp-admin/includes/image-edit.php' );
     136        require_once ABSPATH . 'wp-admin/includes/image-edit.php';
    137137
    138138        // Mime types.
Note: See TracChangeset for help on using the changeset viewer.