Changeset 47198 for trunk/tests/phpunit/tests/menu/wpExpandNavMenuPostData.php

Timestamp:

02/06/2020 06:31:22 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.

This avoids the performance overhead of the function call every time dirname( __FILE__ ) was used instead of __DIR__.

This commit also includes:

• Removing unnecessary parentheses from include/require statements. These are language constructs, not function calls.
• Replacing include statements for several files with require_once, for consistency:
  • wp-admin/admin-header.php
  • wp-admin/admin-footer.php
  • wp-includes/version.php

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

File:

• trunk/tests/phpunit/tests/menu/wpExpandNavMenuPostData.php (modified) (3 diffs)

trunk/tests/phpunit/tests/menu/wpExpandNavMenuPostData.php

@@ -7 +7 @@
 class Tests_Menu_WpExpandNavMenuPostData extends WP_UnitTestCase {
     public function test_unnested_data_should_expand() {
-        include_once( ABSPATH . 'wp-admin/includes/nav-menu.php' );
+        require_once ABSPATH . 'wp-admin/includes/nav-menu.php';
 
         if ( empty( $_POST ) ) {
@@ -30 +30 @@
 
     public function test_multidimensional_nested_array_should_expand() {
-        include_once( ABSPATH . 'wp-admin/includes/nav-menu.php' );
+        require_once ABSPATH . 'wp-admin/includes/nav-menu.php';
 
         if ( empty( $_POST ) ) {
@@ -60 +60 @@
 
     public function test_multidimensional_nested_array_should_expand_and_merge() {
-        include_once( ABSPATH . 'wp-admin/includes/nav-menu.php' );
+        require_once ABSPATH . 'wp-admin/includes/nav-menu.php';
 
         if ( empty( $_POST ) ) {