Changeset 47214 for trunk/src/wp-content/themes/twentynineteen/inc/icon-functions.php

Timestamp:

02/08/2020 12:59:44 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Twenty Nineteen: Improve code organization in template-functions.php by moving helper functions into their own file.

These functions are moved to inc/helper-functions.php:

• twentynineteen_can_show_post_thumbnail()
• twentynineteen_image_filters_enabled()
• twentynineteen_get_avatar_size()
• twentynineteen_is_comment_by_post_author()
• twentynineteen_get_discussion_data()
• twentynineteen_hsl_hex()

Additionally, twentynineteen_add_dropdown_icons() is moved to inc/icon-functions.php to join twentynineteen_nav_menu_social_icons().

Props akshayar, allancole, grapplerulrich.
Fixes #45984.

File:

• trunk/src/wp-content/themes/twentynineteen/inc/icon-functions.php (modified) (1 diff)

trunk/src/wp-content/themes/twentynineteen/inc/icon-functions.php

@@ -51 +51 @@
 }
 add_filter( 'walker_nav_menu_start_el', 'twentynineteen_nav_menu_social_icons', 10, 4 );
+
+/**
+ * Add a dropdown icon to top-level menu items.
+ *
+ * @param string $output Nav menu item start element.
+ * @param object $item   Nav menu item.
+ * @param int    $depth  Depth.
+ * @param object $args   Nav menu args.
+ * @return string Nav menu item start element.
+ * Add a dropdown icon to top-level menu items
+ */
+function twentynineteen_add_dropdown_icons( $output, $item, $depth, $args ) {
+
+    // Only add class to 'top level' items on the 'primary' menu.
+    if ( ! isset( $args->theme_location ) || 'menu-1' !== $args->theme_location ) {
+        return $output;
+    }
+
+    if ( in_array( 'mobile-parent-nav-menu-item', $item->classes, true ) && isset( $item->original_id ) ) {
+        // Inject the keyboard_arrow_left SVG inside the parent nav menu item, and let the item link to the parent item.
+        // @todo Only do this for nested submenus? If on a first-level submenu, then really the link could be "#" since the desire is to remove the target entirely.
+        $link = sprintf(
+            '<button class="menu-item-link-return" tabindex="-1">%s',
+            twentynineteen_get_icon_svg( 'chevron_left', 24 )
+        );
+
+        // Replace opening <a> with <button>.
+        $output = preg_replace(
+            '/<a\s.*?>/',
+            $link,
+            $output,
+            1 // Limit.
+        );
+
+        // Replace closing </a> with </button>.
+        $output = preg_replace(
+            '#</a>#i',
+            '</button>',
+            $output,
+            1 // Limit.
+        );
+
+    } elseif ( in_array( 'menu-item-has-children', $item->classes, true ) ) {
+
+        // Add SVG icon to parent items.
+        $icon = twentynineteen_get_icon_svg( 'keyboard_arrow_down', 24 );
+
+        $output .= sprintf(
+            '<button class="submenu-expand" tabindex="-1">%s</button>',
+            $icon
+        );
+    }
+
+    return $output;
+}
+add_filter( 'walker_nav_menu_start_el', 'twentynineteen_add_dropdown_icons', 10, 4 );