Changeset 47215

Timestamp:

02/08/2020 08:08:31 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Only get MySQL server information in tests where it's actually needed.

This resolves an issue with plugins like HyperDB, which doesn't have a database connection until a query is made.

Props xkon, Otto42, Clorith.
See #47606.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -33 +33 @@
         public function __construct() {
                 $this->maybe_create_scheduled_event();
-
-                $this->prepare_sql_data();
 
                 $this->timeout_late_cron   = 0;
@@ -1096 +1094 @@
          */
         public function get_test_sql_server() {
+                if ( ! $this->mysql_server_version ) {
+                        $this->prepare_sql_data();
+                }
+
                 $result = array(
                         'label'       => __( 'SQL server is up to date' ),
@@ -1182 +1184 @@
         public function get_test_utf8mb4_support() {
                 global $wpdb;
+
+                if ( ! $this->mysql_server_version ) {
+                        $this->prepare_sql_data();
+                }
 
                 $result = array(