Changeset 47218 for trunk/src/wp-admin/admin.php

Timestamp:

02/09/2020 04:51:22 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions in some wp-admin files.

Props subrataemfluence, marcio-zebedeu, bookdude13, 1naveengiri, alishankhan.
Fixes #44365, #48455.

File:

• trunk/src/wp-admin/admin.php (modified) (3 diffs)

trunk/src/wp-admin/admin.php

@@ -73 +73 @@
          * attempt to do no more than threshold value, with some +/- allowed.
          */
-        if ( $c <= 50 || ( $c > 50 && mt_rand( 0, (int) ( $c / 50 ) ) == 1 ) ) {
+        if ( $c <= 50 || ( $c > 50 && mt_rand( 0, (int) ( $c / 50 ) ) === 1 ) ) {
             require_once ABSPATH . WPINC . '/http.php';
             $response = wp_remote_get(
@@ -182 +182 @@
 
         // Back-compat for plugins using add_management_page().
-        if ( empty( $page_hook ) && 'edit.php' == $pagenow && '' != get_plugin_page_hook( $plugin_page, 'tools.php' ) ) {
+        if ( empty( $page_hook ) && 'edit.php' === $pagenow && '' !== get_plugin_page_hook( $plugin_page, 'tools.php' ) ) {
             // There could be plugin specific params on the URL, so we need the whole query string.
             if ( ! empty( $_SERVER['QUERY_STRING'] ) ) {
@@ -371 +371 @@
      * In all other cases, 'load-' . $pagenow should be used instead.
      */
-    if ( $typenow == 'page' ) {
-        if ( $pagenow == 'post-new.php' ) {
+    if ( 'page' === $typenow ) {
+        if ( 'post-new.php' === $pagenow ) {
             do_action( 'load-page-new.php' ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores
-        } elseif ( $pagenow == 'post.php' ) {
+        } elseif ( 'post.php' === $pagenow ) {
             do_action( 'load-page.php' ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores
         }
-    } elseif ( $pagenow == 'edit-tags.php' ) {
-        if ( $taxnow == 'category' ) {
+    } elseif ( 'edit-tags.php' === $pagenow ) {
+        if ( 'category' === $taxnow ) {
             do_action( 'load-categories.php' ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores
-        } elseif ( $taxnow == 'link_category' ) {
+        } elseif ( 'link_category' === $taxnow ) {
             do_action( 'load-edit-link-categories.php' ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores
         }