Changeset 47218 for trunk/src/wp-admin/update-core.php

Timestamp:

02/09/2020 04:51:22 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions in some wp-admin files.

Props subrataemfluence, marcio-zebedeu, bookdude13, 1naveengiri, alishankhan.
Fixes #44365, #48455.

File:

• trunk/src/wp-admin/update-core.php (modified) (13 diffs)

trunk/src/wp-admin/update-core.php

@@ -43 +43 @@
     $version_string = sprintf( '%s&ndash;<strong>%s</strong>', $update->current, $update->locale );
 
-    if ( 'en_US' == $update->locale && 'en_US' == get_locale() ) {
+    if ( 'en_US' === $update->locale && 'en_US' === get_locale() ) {
         $version_string = $update->current;
-    } elseif ( 'en_US' == $update->locale && $update->packages->partial && $wp_version == $update->partial_version ) {
+    } elseif ( 'en_US' === $update->locale && $update->packages->partial && $wp_version == $update->partial_version ) {
         $updates = get_core_updates();
         if ( $updates && 1 == count( $updates ) ) {
@@ -54 +54 @@
 
     $current = false;
-    if ( ! isset( $update->response ) || 'latest' == $update->response ) {
+    if ( ! isset( $update->response ) || 'latest' === $update->response ) {
         $current = true;
     }
@@ -62 +62 @@
     $mysql_version = $wpdb->db_version();
     $show_buttons  = true;
-    if ( 'development' == $update->response ) {
+    if ( 'development' === $update->response ) {
         $message = __( 'You are using a development version of WordPress. You can update to the latest nightly build automatically:' );
     } else {
@@ -154 +154 @@
         }
     }
-    if ( 'en_US' != $update->locale ) {
+    if ( 'en_US' !== $update->locale ) {
         if ( ! isset( $update->dismissed ) || ! $update->dismissed ) {
             submit_button( __( 'Hide this update' ), '', 'dismiss', false );
@@ -162 +162 @@
     }
     echo '</p>';
-    if ( 'en_US' != $update->locale && ( ! isset( $wp_local_package ) || $wp_local_package != $update->locale ) ) {
+    if ( 'en_US' !== $update->locale && ( ! isset( $wp_local_package ) || $wp_local_package != $update->locale ) ) {
         echo '<p class="hint">' . __( 'This localized version contains both the translation and various other localization fixes.' ) . '</p>';
-    } elseif ( 'en_US' == $update->locale && get_locale() != 'en_US' && ( ! $update->packages->partial && $wp_version == $update->partial_version ) ) {
+    } elseif ( 'en_US' === $update->locale && 'en_US' !== get_locale() && ( ! $update->packages->partial && $wp_version == $update->partial_version ) ) {
         // Partial builds don't need language-specific warnings.
         echo '<p class="hint">' . sprintf(
             /* translators: %s: WordPress version. */
             __( 'You are about to install WordPress %s <strong>in English (US).</strong> There is a chance this update will break your translation. You may prefer to wait for the localized version to be released.' ),
-            $update->response != 'development' ? $update->current : ''
+            'development' !== $update->response ? $update->current : ''
         ) . '</p>';
     }
@@ -226 +226 @@
     $updates    = get_core_updates();
 
-    if ( ! isset( $updates[0]->response ) || 'latest' == $updates[0]->response ) {
+    if ( ! isset( $updates[0]->response ) || 'latest' === $updates[0]->response ) {
         echo '<h2>';
         _e( 'You have the latest version of WordPress.' );
@@ -257 +257 @@
     }
 
-    if ( isset( $updates[0] ) && $updates[0]->response == 'development' ) {
+    if ( isset( $updates[0] ) && 'development' === $updates[0]->response ) {
         require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
         $upgrader = new WP_Automatic_Updater;
@@ -275 +275 @@
     echo '</ul>';
     // Don't show the maintenance mode notice when we are only showing a single re-install option.
-    if ( $updates && ( count( $updates ) > 1 || $updates[0]->response != 'latest' ) ) {
+    if ( $updates && ( count( $updates ) > 1 || 'latest' !== $updates[0]->response ) ) {
         echo '<p>' . __( 'While your site is being updated, it will be in maintenance mode. As soon as your updates are complete, your site will return to normal.' ) . '</p>';
     } elseif ( ! $updates ) {
@@ -308 +308 @@
 
     $core_updates = get_core_updates();
-    if ( ! isset( $core_updates[0]->response ) || 'latest' == $core_updates[0]->response || 'development' == $core_updates[0]->response || version_compare( $core_updates[0]->current, $cur_wp_version, '=' ) ) {
+    if ( ! isset( $core_updates[0]->response ) || 'latest' === $core_updates[0]->response || 'development' === $core_updates[0]->response || version_compare( $core_updates[0]->current, $cur_wp_version, '=' ) ) {
         $core_update_version = false;
     } else {
@@ -530 +530 @@
     $updates = wp_get_translation_updates();
     if ( ! $updates ) {
-        if ( 'en_US' != get_locale() ) {
+        if ( 'en_US' !== get_locale() ) {
             echo '<h2>' . __( 'Translations' ) . '</h2>';
             echo '<p>' . __( 'Your translations are all up to date.' ) . '</p>';
@@ -693 +693 @@
 if ( ( 'do-theme-upgrade' == $action || ( 'do-plugin-upgrade' == $action && ! isset( $_GET['plugins'] ) ) )
     && ! isset( $_POST['checked'] ) ) {
-    $upgrade_error = $action == 'do-theme-upgrade' ? 'themes' : 'plugins';
+    $upgrade_error = 'do-theme-upgrade' == $action ? 'themes' : 'plugins';
     $action        = 'upgrade-core';
 }
@@ -714 +714 @@
 $updates_howto .= '<p>' . __( '<strong>Themes and Plugins</strong> &mdash; To update individual themes or plugins from this screen, use the checkboxes to make your selection, then <strong>click on the appropriate &#8220;Update&#8221; button</strong>. To update all of your themes or plugins at once, you can check the box at the top of the section to select all before clicking the update button.' ) . '</p>';
 
-if ( 'en_US' != get_locale() ) {
+if ( 'en_US' !== get_locale() ) {
     $updates_howto .= '<p>' . __( '<strong>Translations</strong> &mdash; The files translating WordPress into your language are updated for you whenever any other updates occur. But if these files are out of date, you can <strong>click the &#8220;Update Translations&#8221;</strong> button.' ) . '</p>';
 }
@@ -744 +744 @@
     if ( $upgrade_error ) {
         echo '<div class="error"><p>';
-        if ( $upgrade_error == 'themes' ) {
+        if ( 'themes' === $upgrade_error ) {
             _e( 'Please select one or more themes to update.' );
         } else {