Changeset 47219 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

02/09/2020 04:52:28 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions where appropriate.

See #49222.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (20 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -150 +150 @@
      * ensure it's a non-negative, non-zero integer.
      */
-    if ( ( $term_search_min_chars == 0 ) || ( strlen( $s ) < $term_search_min_chars ) ) {
+    if ( ( 0 == $term_search_min_chars ) || ( strlen( $s ) < $term_search_min_chars ) ) {
         wp_die();
     }
@@ -296 +296 @@
     }
 
-    $include_blog_users = ( $type == 'search' ? get_users(
+    $include_blog_users = ( 'search' === $type ? get_users(
         array(
             'blog_id' => $id,
@@ -303 +303 @@
     ) : array() );
 
-    $exclude_blog_users = ( $type == 'add' ? get_users(
+    $exclude_blog_users = ( 'add' === $type ? get_users(
         array(
             'blog_id' => $id,
@@ -392 +392 @@
 
     $pagenow = $_GET['pagenow'];
-    if ( $pagenow === 'dashboard-user' || $pagenow === 'dashboard-network' || $pagenow === 'dashboard' ) {
+    if ( 'dashboard-user' === $pagenow || 'dashboard-network' === $pagenow || 'dashboard' === $pagenow ) {
         set_current_screen( $pagenow );
     }
@@ -574 +574 @@
     }
 
-    if ( $taxonomy->name == 'category' ) {
+    if ( 'category' === $taxonomy->name ) {
         $post_category = isset( $_POST['post_category'] ) ? (array) $_POST['post_category'] : array();
     } else {
@@ -718 +718 @@
 
         // Undo trash, not in trash.
-        if ( ! isset( $_POST['comment_status'] ) || $_POST['comment_status'] != 'trash' ) {
+        if ( ! isset( $_POST['comment_status'] ) || 'trash' !== $_POST['comment_status'] ) {
             $delta = 1;
         }
@@ -735 +735 @@
 
         // Undo spam, not in spam.
-        if ( ! isset( $_POST['comment_status'] ) || $_POST['comment_status'] != 'spam' ) {
+        if ( ! isset( $_POST['comment_status'] ) || 'spam' !== $_POST['comment_status'] ) {
             $delta = 1;
         }
@@ -1319 +1319 @@
         $parent = get_comment( $comment_parent );
 
-        if ( $parent && $parent->comment_approved === '0' && $parent->comment_post_ID == $comment_post_ID ) {
+        if ( $parent && '0' === $parent->comment_approved && $parent->comment_post_ID == $comment_post_ID ) {
             if ( ! current_user_can( 'edit_comment', $parent->comment_ID ) ) {
                 wp_die( -1 );
@@ -1550 +1550 @@
 
         // If the post is an autodraft, save the post as a draft and then attempt to save the meta.
-        if ( $post->post_status == 'auto-draft' ) {
+        if ( 'auto-draft' === $post->post_status ) {
             $post_data                = array();
             $post_data['action']      = 'draft'; // Warning fix.
@@ -1721 +1721 @@
     $page = isset( $_POST['page'] ) ? $_POST['page'] : '';
 
-    if ( $page != sanitize_key( $page ) ) {
+    if ( sanitize_key( $page ) != $page ) {
         wp_die( 0 );
     }
@@ -1752 +1752 @@
     $page = isset( $_POST['page'] ) ? $_POST['page'] : '';
 
-    if ( $page != sanitize_key( $page ) ) {
+    if ( sanitize_key( $page ) != $page ) {
         wp_die( 0 );
     }
@@ -1901 +1901 @@
     $page_columns = isset( $_POST['page_columns'] ) ? $_POST['page_columns'] : 'auto';
 
-    if ( $page_columns != 'auto' ) {
+    if ( 'auto' !== $page_columns ) {
         $page_columns = (int) $page_columns;
     }
@@ -1907 +1907 @@
     $page = isset( $_POST['page'] ) ? $_POST['page'] : '';
 
-    if ( $page != sanitize_key( $page ) ) {
+    if ( sanitize_key( $page ) != $page ) {
         wp_die( 0 );
     }
@@ -2004 +2004 @@
         $msg_template = __( 'Saving is disabled: %s is currently editing this post.' );
 
-        if ( $_POST['post_type'] == 'page' ) {
+        if ( 'page' === $_POST['post_type'] ) {
             /* translators: %s: User's display name. */
             $msg_template = __( 'Saving is disabled: %s is currently editing this page.' );
@@ -2068 +2068 @@
     $wp_list_table = _get_list_table( 'WP_Posts_List_Table', array( 'screen' => $_POST['screen'] ) );
 
-    $mode = $_POST['post_view'] === 'excerpt' ? 'excerpt' : 'list';
+    $mode = 'excerpt' === $_POST['post_view'] ? 'excerpt' : 'list';
 
     $level = 0;
@@ -2640 +2640 @@
     }
 
-    if ( $thumbnail_id == '-1' ) {
+    if ( '-1' == $thumbnail_id ) {
         if ( delete_post_thumbnail( $post_ID ) ) {
             $return = _wp_post_thumbnail_html( null, $post_ID );
@@ -2820 +2820 @@
     $active_lock = array_map( 'absint', explode( ':', $_POST['active_post_lock'] ) );
 
-    if ( $active_lock[1] != get_current_user_id() ) {
+    if ( get_current_user_id() != $active_lock[1] ) {
         wp_die( 0 );
     }
@@ -2845 +2845 @@
     $pointer = $_POST['pointer'];
 
-    if ( $pointer != sanitize_key( $pointer ) ) {
+    if ( sanitize_key( $pointer ) != $pointer ) {
         wp_die( 0 );
     }
@@ -3023 +3023 @@
     if ( isset( $changes['alt'] ) ) {
         $alt = wp_unslash( $changes['alt'] );
-        if ( $alt != get_post_meta( $id, '_wp_attachment_image_alt', true ) ) {
+        if ( get_post_meta( $id, '_wp_attachment_image_alt', true ) !== $alt ) {
             $alt = wp_strip_all_tags( $alt, true );
             update_post_meta( $id, '_wp_attachment_image_alt', wp_slash( $alt ) );
@@ -3817 +3817 @@
     $sessions = WP_Session_Tokens::get_instance( $user->ID );
 
-    if ( $user->ID === get_current_user_id() ) {
+    if ( get_current_user_id() === $user->ID ) {
         $sessions->destroy_others( wp_get_session_token() );
         $message = __( 'You are now logged out everywhere else.' );