Changeset 47219 for trunk/src/wp-admin/includes/plugin.php

Timestamp:

02/09/2020 04:52:28 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions where appropriate.

See #49222.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (8 diffs)

trunk/src/wp-admin/includes/plugin.php

@@ -1835 +1835 @@
     }
 
-    if ( $pagenow == 'admin.php' && isset( $plugin_page ) ) {
+    if ( 'admin.php' === $pagenow && isset( $plugin_page ) ) {
         foreach ( (array) $menu as $parent_menu ) {
             if ( $parent_menu[2] == $plugin_page ) {
@@ -1867 +1867 @@
                 $parent = $_wp_real_parent_file[ $parent ];
             }
-            if ( ! empty( $typenow ) && ( $submenu_array[2] == "$pagenow?post_type=$typenow" ) ) {
+            if ( ! empty( $typenow ) && ( "$pagenow?post_type=$typenow" === $submenu_array[2] ) ) {
                 $parent_file = $parent;
                 return $parent;
@@ -1936 +1936 @@
                         ( $parent == $plugin_page ) ||
                         ( $plugin_page == $hook ) ||
-                        ( $pagenow == 'admin.php' && $parent1 != $submenu_array[2] ) ||
+                        ( 'admin.php' === $pagenow && $parent1 != $submenu_array[2] ) ||
                         ( ! empty( $typenow ) && $parent == $pagenow . '?post_type=' . $typenow )
                     )
@@ -1961 +1961 @@
                 if ( isset( $plugin_page ) &&
                     ( $plugin_page == $menu_array[2] ) &&
-                    ( $pagenow == 'admin.php' ) &&
+                    ( 'admin.php' === $pagenow ) &&
                     ( $parent1 == $menu_array[2] ) ) {
                         $title = $menu_array[3];
@@ -2157 +2157 @@
  */
 function add_option_whitelist( $new_options, $options = '' ) {
-    if ( $options == '' ) {
+    if ( '' == $options ) {
         global $whitelist_options;
     } else {
@@ -2170 +2170 @@
             } else {
                 $pos = array_search( $key, $whitelist_options[ $page ] );
-                if ( $pos === false ) {
+                if ( false === $pos ) {
                     $whitelist_options[ $page ][] = $key;
                 }
@@ -2192 +2192 @@
  */
 function remove_option_whitelist( $del_options, $options = '' ) {
-    if ( $options == '' ) {
+    if ( '' == $options ) {
         global $whitelist_options;
     } else {
@@ -2202 +2202 @@
             if ( isset( $whitelist_options[ $page ] ) && is_array( $whitelist_options[ $page ] ) ) {
                 $pos = array_search( $key, $whitelist_options[ $page ] );
-                if ( $pos !== false ) {
+                if ( false !== $pos ) {
                     unset( $whitelist_options[ $page ][ $pos ] );
                 }