Changeset 47219 for trunk/src/wp-admin/includes/template.php

Timestamp:

02/09/2020 04:52:28 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions where appropriate.

See #49222.

File:

• trunk/src/wp-admin/includes/template.php (modified) (4 diffs)

trunk/src/wp-admin/includes/template.php

@@ -433 +433 @@
 
     if ( ! $wp_list_table ) {
-        if ( $mode == 'single' ) {
+        if ( 'single' === $mode ) {
             $wp_list_table = _get_list_table( 'WP_Post_Comments_List_Table' );
         } else {
@@ -2196 +2196 @@
 
             // Display "Header Image" if the image was ever used as a header image.
-            if ( ! empty( $meta_header ) && $meta_header == $stylesheet && $header_image !== wp_get_attachment_url( $post->ID ) ) {
+            if ( ! empty( $meta_header ) && $meta_header === $stylesheet && wp_get_attachment_url( $post->ID ) !== $header_image ) {
                 $media_states[] = __( 'Header Image' );
             }
 
             // Display "Current Header Image" if the image is currently the header image.
-            if ( $header_image && $header_image == wp_get_attachment_url( $post->ID ) ) {
+            if ( $header_image && wp_get_attachment_url( $post->ID ) === $header_image ) {
                 $media_states[] = __( 'Current Header Image' );
             }
@@ -2210 +2210 @@
         $meta_background = get_post_meta( $post->ID, '_wp_attachment_is_custom_background', true );
 
-        if ( ! empty( $meta_background ) && $meta_background == $stylesheet ) {
+        if ( ! empty( $meta_background ) && $meta_background === $stylesheet ) {
             $media_states[] = __( 'Background Image' );
 
             $background_image = get_background_image();
-            if ( $background_image && $background_image == wp_get_attachment_url( $post->ID ) ) {
+            if ( $background_image && wp_get_attachment_url( $post->ID ) === $background_image ) {
                 $media_states[] = __( 'Current Background Image' );
             }
@@ -2220 +2220 @@
     }
 
-    if ( $post->ID == get_option( 'site_icon' ) ) {
+    if ( get_option( 'site_icon' ) == $post->ID ) {
         $media_states[] = __( 'Site Icon' );
     }
 
-    if ( $post->ID == get_theme_mod( 'custom_logo' ) ) {
+    if ( get_theme_mod( 'custom_logo' ) == $post->ID ) {
         $media_states[] = __( 'Logo' );
     }