Changeset 47219 for trunk/src/wp-admin/includes/upgrade.php

Timestamp:

02/09/2020 04:52:28 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions where appropriate.

See #49222.

File:

• trunk/src/wp-admin/includes/upgrade.php (modified) (13 diffs)

trunk/src/wp-admin/includes/upgrade.php

@@ -162 +162 @@
                 if ( global_terms_enabled() ) {
                         $cat_id = $wpdb->get_var( $wpdb->prepare( "SELECT cat_ID FROM {$wpdb->sitecategories} WHERE category_nicename = %s", $cat_slug ) );
-                        if ( $cat_id == null ) {
+                        if ( null == $cat_id ) {
                                 $wpdb->insert(
                                         $wpdb->sitecategories,
@@ -496 +496 @@
                         // Delete any caps that snuck into the previously active blog. (Hardcoded to blog 1 for now.)
                         // TODO: Get previous_blog_id.
-                        if ( ! is_super_admin( $user_id ) && $user_id != 1 ) {
+                        if ( ! is_super_admin( $user_id ) && 1 != $user_id ) {
                                 $wpdb->delete(
                                         $wpdb->usermeta,
@@ -567 +567 @@
                 $response          = wp_remote_get( $test_url, array( 'timeout' => 5 ) );
                 $x_pingback_header = wp_remote_retrieve_header( $response, 'x-pingback' );
-                $pretty_permalinks = $x_pingback_header && $x_pingback_header === get_bloginfo( 'pingback_url' );
+                $pretty_permalinks = $x_pingback_header && get_bloginfo( 'pingback_url' ) === $x_pingback_header;
 
                 if ( $pretty_permalinks ) {
@@ -1128 +1128 @@
                 if ( isset( $user->user_idmode ) ) :
                         $idmode = $user->user_idmode;
-                        if ( $idmode == 'nickname' ) {
+                        if ( 'nickname' === $idmode ) {
                                 $id = $user->user_nickname;
                         }
-                        if ( $idmode == 'login' ) {
+                        if ( 'login' === $idmode ) {
                                 $id = $user->user_login;
                         }
-                        if ( $idmode == 'firstname' ) {
+                        if ( 'firstname' === $idmode ) {
                                 $id = $user->user_firstname;
                         }
-                        if ( $idmode == 'lastname' ) {
+                        if ( 'lastname' === $idmode ) {
                                 $id = $user->user_lastname;
                         }
-                        if ( $idmode == 'namefl' ) {
+                        if ( 'namefl' === $idmode ) {
                                 $id = $user->user_firstname . ' ' . $user->user_lastname;
                         }
-                        if ( $idmode == 'namelf' ) {
+                        if ( 'namelf' === $idmode ) {
                                 $id = $user->user_lastname . ' ' . $user->user_firstname;
                         }
@@ -2250 +2250 @@
 
         // 4.2
-        if ( $wp_current_db_version < 31351 && $wpdb->charset === 'utf8mb4' ) {
+        if ( $wp_current_db_version < 31351 && 'utf8mb4' === $wpdb->charset ) {
                 if ( wp_should_upgrade_global_tables() ) {
                         $wpdb->query( "ALTER TABLE $wpdb->usermeta DROP INDEX meta_key, ADD INDEX meta_key(meta_key(191))" );
@@ -2500 +2500 @@
         global $wpdb;
 
-        if ( $setting == 'home' && defined( 'WP_HOME' ) ) {
+        if ( 'home' === $setting && defined( 'WP_HOME' ) ) {
                 return untrailingslashit( WP_HOME );
         }
 
-        if ( $setting == 'siteurl' && defined( 'WP_SITEURL' ) ) {
+        if ( 'siteurl' === $setting && defined( 'WP_SITEURL' ) ) {
                 return untrailingslashit( WP_SITEURL );
         }
@@ -2510 +2510 @@
         $option = $wpdb->get_var( $wpdb->prepare( "SELECT option_value FROM $wpdb->options WHERE option_name = %s", $setting ) );
 
-        if ( 'home' == $setting && '' == $option ) {
+        if ( 'home' === $setting && '' == $option ) {
                 return __get_option( 'siteurl' );
         }
 
-        if ( 'siteurl' == $setting || 'home' == $setting || 'category_base' == $setting || 'tag_base' == $setting ) {
+        if ( 'siteurl' === $setting || 'home' === $setting || 'category_base' === $setting || 'tag_base' === $setting ) {
                 $option = untrailingslashit( $option );
         }
@@ -2862 +2862 @@
                                         'subpart'   => $tableindex->Sub_part,
                                 );
-                                $index_ary[ $keyname ]['unique']     = ( $tableindex->Non_unique == 0 ) ? true : false;
+                                $index_ary[ $keyname ]['unique']     = ( 0 == $tableindex->Non_unique ) ? true : false;
                                 $index_ary[ $keyname ]['index_type'] = $tableindex->Index_type;
                         }
@@ -2871 +2871 @@
                                 // Build a create string to compare to the query.
                                 $index_string = '';
-                                if ( $index_name == 'primary' ) {
+                                if ( 'primary' === $index_name ) {
                                         $index_string .= 'PRIMARY ';
                                 } elseif ( $index_data['unique'] ) {
@@ -2890 +2890 @@
                                 // For each column in the index.
                                 foreach ( $index_data['columns'] as $column_data ) {
-                                        if ( $index_columns != '' ) {
+                                        if ( '' != $index_columns ) {
                                                 $index_columns .= ',';
                                         }
@@ -3001 +3001 @@
 
         foreach ( $files as $oldfile => $newfile ) {
-                if ( $oldfile == 'index.php' ) {
+                if ( 'index.php' === $oldfile ) {
                         $oldpath = $home_path;
                 } else {
@@ -3008 +3008 @@
 
                 // Check to make sure it's not a new index.
-                if ( $oldfile == 'index.php' ) {
+                if ( 'index.php' === $oldfile ) {
                         $index = implode( '', file( "$oldpath/$oldfile" ) );
                         if ( strpos( $index, 'WP_USE_THEMES' ) !== false ) {
@@ -3184 +3184 @@
         // Make the new site theme active.
         $current_template = __get_option( 'template' );
-        if ( $current_template == WP_DEFAULT_THEME ) {
+        if ( WP_DEFAULT_THEME == $current_template ) {
                 update_option( 'template', $template );
                 update_option( 'stylesheet', $template );