Changeset 47219 for trunk/src/wp-includes/class-wp-query.php

Timestamp:

02/09/2020 04:52:28 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions where appropriate.

See #49222.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (14 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -911 +911 @@
             unset( $tax_query );
 
-            if ( empty( $qv['author'] ) || ( $qv['author'] == '0' ) ) {
+            if ( empty( $qv['author'] ) || ( '0' == $qv['author'] ) ) {
                 $this->is_author = false;
             } else {
@@ -1018 +1018 @@
             }
 
-            if ( 'page' == get_option( 'show_on_front' ) && isset( $this->queried_object_id ) && $this->queried_object_id == get_option( 'page_for_posts' ) ) {
+            if ( 'page' === get_option( 'show_on_front' ) && isset( $this->queried_object_id ) && get_option( 'page_for_posts' ) == $this->queried_object_id ) {
                 $this->is_page       = false;
                 $this->is_home       = true;
@@ -1024 +1024 @@
             }
 
-            if ( isset( $this->queried_object_id ) && $this->queried_object_id == get_option( 'wp_page_for_privacy_policy' ) ) {
+            if ( isset( $this->queried_object_id ) && get_option( 'wp_page_for_privacy_policy' ) == $this->queried_object_id ) {
                 $this->is_privacy_policy = true;
             }
@@ -1030 +1030 @@
 
         if ( $qv['page_id'] ) {
-            if ( 'page' == get_option( 'show_on_front' ) && $qv['page_id'] == get_option( 'page_for_posts' ) ) {
+            if ( 'page' === get_option( 'show_on_front' ) && get_option( 'page_for_posts' ) == $qv['page_id'] ) {
                 $this->is_page       = false;
                 $this->is_home       = true;
@@ -1036 +1036 @@
             }
 
-            if ( $qv['page_id'] == get_option( 'wp_page_for_privacy_policy' ) ) {
+            if ( get_option( 'wp_page_for_privacy_policy' ) == $qv['page_id'] ) {
                 $this->is_privacy_policy = true;
             }
@@ -1378 +1378 @@
         foreach ( $q['search_terms'] as $term ) {
             // If there is an $exclusion_prefix, terms prefixed with it should be excluded.
-            $exclude = $exclusion_prefix && ( $exclusion_prefix === substr( $term, 0, 1 ) );
+            $exclude = $exclusion_prefix && ( substr( $term, 0, 1 ) === $exclusion_prefix );
             if ( $exclude ) {
                 $like_op  = 'NOT LIKE';
@@ -1862 +1862 @@
             $q['posts_per_page'] = $q['showposts'];
         }
-        if ( ( isset( $q['posts_per_archive_page'] ) && $q['posts_per_archive_page'] != 0 ) && ( $this->is_archive || $this->is_search ) ) {
+        if ( ( isset( $q['posts_per_archive_page'] ) && 0 != $q['posts_per_archive_page'] ) && ( $this->is_archive || $this->is_search ) ) {
             $q['posts_per_page'] = $q['posts_per_archive_page'];
         }
         if ( ! isset( $q['nopaging'] ) ) {
-            if ( $q['posts_per_page'] == -1 ) {
+            if ( -1 == $q['posts_per_page'] ) {
                 $q['nopaging'] = true;
             } else {
@@ -1885 +1885 @@
         if ( $q['posts_per_page'] < -1 ) {
             $q['posts_per_page'] = abs( $q['posts_per_page'] );
-        } elseif ( $q['posts_per_page'] == 0 ) {
+        } elseif ( 0 == $q['posts_per_page'] ) {
             $q['posts_per_page'] = 1;
         }
 
-        if ( ! isset( $q['comments_per_page'] ) || $q['comments_per_page'] == 0 ) {
+        if ( ! isset( $q['comments_per_page'] ) || 0 == $q['comments_per_page'] ) {
             $q['comments_per_page'] = get_option( 'comments_per_page' );
         }
 
-        if ( $this->is_home && ( empty( $this->query ) || $q['preview'] == 'true' ) && ( 'page' == get_option( 'show_on_front' ) ) && get_option( 'page_on_front' ) ) {
+        if ( $this->is_home && ( empty( $this->query ) || 'true' === $q['preview'] ) && ( 'page' === get_option( 'show_on_front' ) ) && get_option( 'page_on_front' ) ) {
             $this->is_page = true;
             $this->is_home = false;
@@ -2097 +2097 @@
 
         if ( $q['page_id'] ) {
-            if ( ( 'page' != get_option( 'show_on_front' ) ) || ( $q['page_id'] != get_option( 'page_for_posts' ) ) ) {
+            if ( ( 'page' !== get_option( 'show_on_front' ) ) || ( get_option( 'page_for_posts' ) != $q['page_id'] ) ) {
                 $q['p'] = $q['page_id'];
                 $where  = " AND {$wpdb->posts}.ID = " . $q['page_id'];
@@ -2136 +2136 @@
                 $taxonomies = array_keys( $this->tax_query->queried_terms );
                 foreach ( get_post_types( array( 'exclude_from_search' => false ) ) as $pt ) {
-                    $object_taxonomies = $pt === 'attachment' ? get_taxonomies_for_attachments() : get_object_taxonomies( $pt );
+                    $object_taxonomies = 'attachment' === $pt ? get_taxonomies_for_attachments() : get_object_taxonomies( $pt );
                     if ( array_intersect( $taxonomies, $object_taxonomies ) ) {
                         $post_type[] = $pt;
@@ -2215 +2215 @@
         // Author/user stuff.
 
-        if ( ! empty( $q['author'] ) && $q['author'] != '0' ) {
+        if ( ! empty( $q['author'] ) && '0' != $q['author'] ) {
             $q['author'] = addslashes_gpc( '' . urldecode( $q['author'] ) );
             $authors     = array_unique( array_map( 'intval', preg_split( '/[,\s]+/', $q['author'] ) ) );
@@ -3291 +3291 @@
         $this->in_the_loop = true;
 
-        if ( $this->current_post == -1 ) { // Loop has just started.
+        if ( -1 == $this->current_post ) { // Loop has just started.
             /**
              * Fires once the loop is started.
@@ -3381 +3381 @@
         $comment = $this->next_comment();
 
-        if ( $this->current_comment == 0 ) {
+        if ( 0 == $this->current_comment ) {
             /**
              * Fires once the comment loop is started.
@@ -4301 +4301 @@
          * or when on an RSS feed. Otherwise respect the 'more' tag.
          */
-        if ( $post->ID === get_queried_object_id() && ( $this->is_page() || $this->is_single() ) ) {
+        if ( get_queried_object_id() === $post->ID && ( $this->is_page() || $this->is_single() ) ) {
             $more = 1;
         } elseif ( $this->is_feed() ) {