Changeset 47219 for trunk/src/wp-includes/comment.php

Timestamp:

02/09/2020 04:52:28 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions where appropriate.

See #49222.

File:

• trunk/src/wp-includes/comment.php (modified) (8 diffs)

trunk/src/wp-includes/comment.php

@@ -128 +128 @@
      */
     if ( 1 == get_option( 'comment_whitelist' ) ) {
-        if ( 'trackback' != $comment_type && 'pingback' != $comment_type && $author != '' && $email != '' ) {
+        if ( 'trackback' !== $comment_type && 'pingback' !== $comment_type && '' != $author && '' != $email ) {
             $comment_user = get_user_by( 'email', wp_unslash( $email ) );
             if ( ! empty( $comment_user->ID ) ) {
@@ -218 +218 @@
     $_comment = apply_filters( 'get_comment', $_comment );
 
-    if ( $output == OBJECT ) {
+    if ( OBJECT == $output ) {
         return $_comment;
-    } elseif ( $output == ARRAY_A ) {
+    } elseif ( ARRAY_A == $output ) {
         return $_comment->to_array();
-    } elseif ( $output == ARRAY_N ) {
+    } elseif ( ARRAY_N == $output ) {
         return array_values( $_comment->to_array() );
     }
@@ -1430 +1430 @@
 
     $post_id = $comment->comment_post_ID;
-    if ( $post_id && $comment->comment_approved == 1 ) {
+    if ( $post_id && 1 == $comment->comment_approved ) {
         wp_update_comment_count( $post_id );
     }
@@ -1656 +1656 @@
     $approved = $comment->comment_approved;
 
-    if ( $approved == null ) {
+    if ( null == $approved ) {
         return false;
-    } elseif ( $approved == '1' ) {
+    } elseif ( '1' == $approved ) {
         return 'approved';
-    } elseif ( $approved == '0' ) {
+    } elseif ( '0' == $approved ) {
         return 'unapproved';
-    } elseif ( $approved == 'spam' ) {
+    } elseif ( 'spam' == $approved ) {
         return 'spam';
-    } elseif ( $approved == 'trash' ) {
+    } elseif ( 'trash' == $approved ) {
         return 'trash';
     } else {
@@ -1914 +1914 @@
     $id = (int) $wpdb->insert_id;
 
-    if ( $comment_approved == 1 ) {
+    if ( 1 == $comment_approved ) {
         wp_update_comment_count( $comment_post_ID );
 
@@ -2633 +2633 @@
     if ( $pingback_link_offset_dquote || $pingback_link_offset_squote ) {
         $quote                   = ( $pingback_link_offset_dquote ) ? '"' : '\'';
-        $pingback_link_offset    = ( $quote == '"' ) ? $pingback_link_offset_dquote : $pingback_link_offset_squote;
+        $pingback_link_offset    = ( '"' === $quote ) ? $pingback_link_offset_dquote : $pingback_link_offset_squote;
         $pingback_href_pos       = strpos( $contents, 'href=', $pingback_link_offset );
         $pingback_href_start     = $pingback_href_pos + 6;
@@ -2844 +2844 @@
                 if ( isset( $test['query'] ) ) {
                     $post_links[] = $link_test;
-                } elseif ( isset( $test['path'] ) && ( $test['path'] != '/' ) && ( $test['path'] != '' ) ) {
+                } elseif ( isset( $test['path'] ) && ( '/' !== $test['path'] ) && ( '' !== $test['path'] ) ) {
                     $post_links[] = $link_test;
                 }
@@ -3006 +3006 @@
  */
 function xmlrpc_pingback_error( $ixr_error ) {
-    if ( $ixr_error->code === 48 ) {
+    if ( 48 === $ixr_error->code ) {
         return $ixr_error;
     }