Changeset 47219 for trunk/src/wp-includes/kses.php

Timestamp:

02/09/2020 04:52:28 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions where appropriate.

See #49222.

File:

• trunk/src/wp-includes/kses.php (modified) (8 diffs)

trunk/src/wp-includes/kses.php

@@ -1047 +1047 @@
         if ( '<!--' == substr( $string, 0, 4 ) ) {
                 $string = str_replace( array( '<!--', '-->' ), '', $string );
-                while ( $string != ( $newstring = wp_kses( $string, $allowed_html, $allowed_protocols ) ) ) {
+                while ( ( $newstring = wp_kses( $string, $allowed_html, $allowed_protocols ) ) != $string ) {
                         $string = $newstring;
                 }
-                if ( $string == '' ) {
+                if ( '' == $string ) {
                         return '';
                 }
@@ -1079 +1079 @@
 
         // No attributes are allowed for closing elements.
-        if ( $slash != '' ) {
+        if ( '' != $slash ) {
                 return "</$elem>";
         }
@@ -1349 +1349 @@
                 } // End switch.
 
-                if ( $working == 0 ) { // Not well-formed, remove and try again.
+                if ( 0 == $working ) { // Not well-formed, remove and try again.
                         $attr = wp_kses_html_error( $attr );
                         $mode = 0;
@@ -1355 +1355 @@
         } // End while.
 
-        if ( $mode == 1 && false === array_key_exists( $attrname, $attrarr ) ) {
+        if ( 1 == $mode && false === array_key_exists( $attrname, $attrarr ) ) {
                 // Special case, for when the attribute list ends with a valueless
                 // attribute like "selected".
@@ -1846 +1846 @@
  */
 function valid_unicode( $i ) {
-        return ( $i == 0x9 || $i == 0xa || $i == 0xd ||
-                        ( $i >= 0x20 && $i <= 0xd7ff ) ||
-                        ( $i >= 0xe000 && $i <= 0xfffd ) ||
-                        ( $i >= 0x10000 && $i <= 0x10ffff ) );
+        return ( 0x9 == $i || 0xa == $i || 0xd == $i ||
+                        ( 0x20 <= $i && $i <= 0xd7ff ) ||
+                        ( 0xe000 <= $i && $i <= 0xfffd ) ||
+                        ( 0x10000 <= $i && $i <= 0x10ffff ) );
 }
 
@@ -2245 +2245 @@
         $css = '';
         foreach ( $css_array as $css_item ) {
-                if ( $css_item == '' ) {
+                if ( '' == $css_item ) {
                         continue;
                 }
@@ -2283 +2283 @@
                                 $url = trim( $url_pieces[2] );
 
-                                if ( empty( $url ) || $url !== wp_kses_bad_protocol( $url, $allowed_protocols ) ) {
+                                if ( empty( $url ) || wp_kses_bad_protocol( $url, $allowed_protocols ) !== $url ) {
                                         $found = false;
                                         break;
@@ -2303 +2303 @@
                 // Remove any CSS containing containing \ ( & } = or comments, except for url() useage checked above.
                 if ( $found && ! preg_match( '%[\\\(&=}]|/\*%', $css_test_string ) ) {
-                        if ( $css != '' ) {
+                        if ( '' != $css ) {
                                 $css .= ';';
                         }