Changeset 47219 for trunk/src/wp-includes/link-template.php

Timestamp:

02/09/2020 04:52:28 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use Yoda conditions where appropriate.

See #49222.

File:

• trunk/src/wp-includes/link-template.php (modified) (14 diffs)

trunk/src/wp-includes/link-template.php

@@ -143 +143 @@
         }
 
-        if ( $post->post_type == 'page' ) {
+        if ( 'page' === $post->post_type ) {
                 return get_page_link( $post, $leavename, $sample );
-        } elseif ( $post->post_type == 'attachment' ) {
+        } elseif ( 'attachment' === $post->post_type ) {
                 return get_attachment_link( $post, $leavename );
         } elseif ( in_array( $post->post_type, get_post_types( array( '_builtin' => false ) ) ) ) {
@@ -333 +333 @@
         $post = get_post( $post );
 
-        if ( 'page' == get_option( 'show_on_front' ) && $post->ID == get_option( 'page_on_front' ) ) {
+        if ( 'page' === get_option( 'show_on_front' ) && get_option( 'page_on_front' ) == $post->ID ) {
                 $link = home_url( '/' );
         } else {
@@ -423 +423 @@
 
         if ( $wp_rewrite->using_permalinks() && $parent ) {
-                if ( 'page' == $parent->post_type ) {
+                if ( 'page' === $parent->post_type ) {
                         $parentlink = _get_page_link( $post->post_parent ); // Ignores page_on_front.
                 } else {
@@ -683 +683 @@
 
         if ( '' != get_option( 'permalink_structure' ) ) {
-                if ( 'page' == get_option( 'show_on_front' ) && $post_id == get_option( 'page_on_front' ) ) {
+                if ( 'page' === get_option( 'show_on_front' ) && get_option( 'page_on_front' ) == $post_id ) {
                         $url = _get_page_link( $post_id );
                 } else {
@@ -691 +691 @@
                 if ( $unattached ) {
                         $url = home_url( '/feed/' );
-                        if ( $feed !== get_default_feed() ) {
+                        if ( get_default_feed() !== $feed ) {
                                 $url .= "$feed/";
                         }
@@ -697 +697 @@
                 } else {
                         $url = trailingslashit( $url ) . 'feed';
-                        if ( $feed != get_default_feed() ) {
+                        if ( get_default_feed() != $feed ) {
                                 $url .= "/$feed";
                         }
@@ -711 +711 @@
                                 home_url( '/' )
                         );
-                } elseif ( 'page' == $post->post_type ) {
+                } elseif ( 'page' === $post->post_type ) {
                         $url = add_query_arg(
                                 array(
@@ -799 +799 @@
         } else {
                 $link = get_author_posts_url( $author_id );
-                if ( $feed == get_default_feed() ) {
+                if ( get_default_feed() == $feed ) {
                         $feed_link = 'feed';
                 } else {
@@ -878 +878 @@
         } else {
                 $link = get_term_link( $term_id, $term->taxonomy );
-                if ( $feed == get_default_feed() ) {
+                if ( get_default_feed() == $feed ) {
                         $feed_link = 'feed';
                 } else {
@@ -1223 +1223 @@
                 $page_for_posts = get_option( 'page_for_posts' );
 
-                if ( 'page' == $show_on_front && $page_for_posts ) {
+                if ( 'page' === $show_on_front && $page_for_posts ) {
                         $link = get_permalink( $page_for_posts );
                 } else {
@@ -3635 +3635 @@
         if ( ! $scheme ) {
                 $scheme = is_ssl() ? 'https' : 'http';
-        } elseif ( $scheme === 'admin' || $scheme === 'login' || $scheme === 'login_post' || $scheme === 'rpc' ) {
+        } elseif ( 'admin' === $scheme || 'login' === $scheme || 'login_post' === $scheme || 'rpc' === $scheme ) {
                 $scheme = is_ssl() || force_ssl_admin() ? 'https' : 'http';
-        } elseif ( $scheme !== 'http' && $scheme !== 'https' && $scheme !== 'relative' ) {
+        } elseif ( 'http' !== $scheme && 'https' !== $scheme && 'relative' !== $scheme ) {
                 $scheme = is_ssl() ? 'https' : 'http';
         }
@@ -3648 +3648 @@
         if ( 'relative' == $scheme ) {
                 $url = ltrim( preg_replace( '#^\w+://[^/]*#', '', $url ) );
-                if ( $url !== '' && $url[0] === '/' ) {
+                if ( '' !== $url && '/' === $url[0] ) {
                         $url = '/' . ltrim( $url, "/ \t\n\r\0\x0B" );
                 }
@@ -3780 +3780 @@
 
         // If a canonical is being generated for the current page, make sure it has pagination if needed.
-        if ( $post->ID === get_queried_object_id() ) {
+        if ( get_queried_object_id() === $post->ID ) {
                 $page = get_query_var( 'page', 0 );
                 if ( $page >= 2 ) {
@@ -3888 +3888 @@
                 $post_type = get_post_type_object( $post->post_type );
 
-                if ( 'page' === $post->post_type && $post->ID == get_option( 'page_on_front' ) && 'page' == get_option( 'show_on_front' ) ) {
+                if ( 'page' === $post->post_type && get_option( 'page_on_front' ) == $post->ID && 'page' === get_option( 'show_on_front' ) ) {
                         $shortlink = home_url( '/' );
                 } elseif ( $post_type->public ) {