Changeset 47221

Timestamp:

02/09/2020 06:24:41 PM (7 years ago)

Author:

joedolson

Message:

Toolbar: Load toolbar in wp_body_open when available.

For accessibility, the visual appearance and source order should match. Moving the toolbar to load in the new hook wp_body_open (5.2) fixes a long-standing source order problem.

Props jankimoradiya, afercia, SergeyBiryukov, audrasjb, ocean90, xkon, dinhtungdu.
Fixes #47053.

Location:

trunk

Files:

• package-lock.json (modified) (11 diffs)
• src/wp-includes/default-filters.php (modified) (1 diff)
• src/wp-includes/general-template.php (modified) (1 diff)

trunk/package-lock.json

@@ -5016 +5016 @@
                 "bl": {
                         "version": "1.2.2",
-                        "resolved": "http://registry.npmjs.org/bl/-/bl-1.2.2.tgz",
+                        "resolved": "https://registry.npmjs.org/bl/-/bl-1.2.2.tgz",
                         "integrity": "sha512-e8tQYnZodmebYDWGH7KMRvtzKXaJHx3BbilrgZCfvyLUYdKpK1t5PSPmpkny/SgiTSCnjfLW7v5rlONXVFkQEA==",
                         "dev": true,
@@ -5207 +5207 @@
                 "browserify-aes": {
                         "version": "1.2.0",
-                        "resolved": "http://registry.npmjs.org/browserify-aes/-/browserify-aes-1.2.0.tgz",
+                        "resolved": "https://registry.npmjs.org/browserify-aes/-/browserify-aes-1.2.0.tgz",
                         "integrity": "sha512-+7CHXqGuspUn/Sl5aO7Ea0xWGAtETPXNSAjHo48JfLdPWcMng33Xe4znFvQweqc/uzk5zSOI3H52CYnjCfb5hA==",
                         "dev": true,
@@ -6497 +6497 @@
                 "create-hash": {
                         "version": "1.2.0",
-                        "resolved": "http://registry.npmjs.org/create-hash/-/create-hash-1.2.0.tgz",
+                        "resolved": "https://registry.npmjs.org/create-hash/-/create-hash-1.2.0.tgz",
                         "integrity": "sha512-z00bCGNHDG8mHAkP7CtT1qVu+bFQUPjYq/4Iv3C3kWjTFV10zIjfSoeqXo9Asws8gwSHDGj/hl2u4OGIjapeCg==",
                         "dev": true,
@@ -6510 +6510 @@
                 "create-hmac": {
                         "version": "1.1.7",
-                        "resolved": "http://registry.npmjs.org/create-hmac/-/create-hmac-1.1.7.tgz",
+                        "resolved": "https://registry.npmjs.org/create-hmac/-/create-hmac-1.1.7.tgz",
                         "integrity": "sha512-MJG9liiZ+ogc4TzUwuvbER1JRdgvUFSB5+VR/g5h82fGaIRWMWddtKBHi7/sVhfjQZ6SehlyhvQYrcYkaUIpLg==",
                         "dev": true,
@@ -6576 +6576 @@
                 "css-color-names": {
                         "version": "0.0.4",
-                        "resolved": "http://registry.npmjs.org/css-color-names/-/css-color-names-0.0.4.tgz",
+                        "resolved": "https://registry.npmjs.org/css-color-names/-/css-color-names-0.0.4.tgz",
                         "integrity": "sha1-gIrcLnnPhHOAabZGyyDsJ762KeA=",
                         "dev": true
@@ -7472 +7472 @@
                 "diffie-hellman": {
                         "version": "5.0.3",
-                        "resolved": "http://registry.npmjs.org/diffie-hellman/-/diffie-hellman-5.0.3.tgz",
+                        "resolved": "https://registry.npmjs.org/diffie-hellman/-/diffie-hellman-5.0.3.tgz",
                         "integrity": "sha512-kqag/Nl+f3GwyK25fhUMYj81BUOrZ9IuJsjIcDE5icNM9FJHAVm3VcUDxdLPoQtTuUylWm6ZIknYJwwaPxsUzg==",
                         "dev": true,
@@ -7693 +7693 @@
                 "duplexer": {
                         "version": "0.1.1",
-                        "resolved": "http://registry.npmjs.org/duplexer/-/duplexer-0.1.1.tgz",
+                        "resolved": "https://registry.npmjs.org/duplexer/-/duplexer-0.1.1.tgz",
                         "integrity": "sha1-rOb/gIwc5mtX0ev5eXessCM0z8E=",
                         "dev": true
@@ -16930 +16930 @@
                                 "progress": {
                                         "version": "1.1.8",
-                                        "resolved": "http://registry.npmjs.org/progress/-/progress-1.1.8.tgz",
+                                        "resolved": "https://registry.npmjs.org/progress/-/progress-1.1.8.tgz",
                                         "integrity": "sha1-4mDHj2Fhzdmw5WzD4Khd4Xx6V74=",
                                         "dev": true
@@ -18117 +18117 @@
                 "react-autosize-textarea": {
                         "version": "3.0.3",
-                        "resolved": "http://registry.npmjs.org/react-autosize-textarea/-/react-autosize-textarea-3.0.3.tgz",
+                        "resolved": "https://registry.npmjs.org/react-autosize-textarea/-/react-autosize-textarea-3.0.3.tgz",
                         "integrity": "sha512-iOSZK7RUuJ+iEwkJ9rqYciqtjQgrG1CCRFL6h8Bk61kODnRyEq4tS74IgXpI1t4S6jBBZVm+6ugaU+tWTlVxXg==",
                         "requires": {
@@ -18529 +18529 @@
                 "regjsgen": {
                         "version": "0.2.0",
-                        "resolved": "http://registry.npmjs.org/regjsgen/-/regjsgen-0.2.0.tgz",
+                        "resolved": "https://registry.npmjs.org/regjsgen/-/regjsgen-0.2.0.tgz",
                         "integrity": "sha1-bAFq3qxVT3WCP+N6wFuS1aTtsfc="
                 },
@@ -19498 +19498 @@
                 "sha.js": {
                         "version": "2.4.11",
-                        "resolved": "http://registry.npmjs.org/sha.js/-/sha.js-2.4.11.tgz",
+                        "resolved": "https://registry.npmjs.org/sha.js/-/sha.js-2.4.11.tgz",
                         "integrity": "sha512-QMEp5B7cftE7APOjk5Y6xgrbWu+WkLVQwk8JNjZ8nKRciZaByEW6MubieAiToS7+dwvrjGhH8jRXz3MVd0AYqQ==",
                         "dev": true,

trunk/src/wp-includes/default-filters.php

@@ -538 +538 @@
 add_action( 'before_signup_header', '_wp_admin_bar_init' );
 add_action( 'activate_header', '_wp_admin_bar_init' );
-add_action( 'wp_footer', 'wp_admin_bar_render', 1000 );
+add_action( 'wp_body_open', 'wp_admin_bar_render', 0 );
 add_action( 'in_admin_header', 'wp_admin_bar_render', 0 );
 

trunk/src/wp-includes/general-template.php

@@ -2891 +2891 @@
 function wp_footer() {
         /**
+         * Sets up the Admin Bar if the current theme does not use `wp_body_open`.
+         *
+         * @since 5.4.0
+         */
+        if ( ! did_action( 'wp_body_open' ) ) {
+                add_action( 'wp_footer', 'wp_admin_bar_render', 1000 );
+        }
+        /**
          * Prints scripts or data before the closing body tag on the front end.
          *