Changeset 47226

Timestamp:

02/10/2020 01:50:33 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Login and Registration: Use CSS animation instead of old JavaScript code for "shake" animation on login failure.

Props markjaquith, valentinbora.
Fixes #48490.

Location:

trunk/src

Files:

• wp-admin/css/login.css (modified) (1 diff)
• wp-login.php (modified) (2 diffs)

trunk/src/wp-admin/css/login.css

@@ -140 +140 @@
 }
 
+.login form.shake {
+    animation: shake 0.2s cubic-bezier(.19,.49,.38,.79) both;
+    animation-iteration-count: 3;
+    transform: translateX(0);
+}
+
+@keyframes shake {
+    25% {
+        transform: translateX(-20px);
+    }
+    75% {
+        transform: translateX(20px);
+    }
+    100% {
+        transform: translateX(0);
+    }
+}
+
 .login-action-confirm_admin_email #login {
     width: 60vw;

trunk/src/wp-login.php

@@ -63 +63 @@
 
     if ( $shake_error_codes && $wp_error->has_errors() && in_array( $wp_error->get_error_code(), $shake_error_codes, true ) ) {
-        add_action( 'login_head', 'wp_shake_js', 12 );
+        add_action( 'login_footer', 'wp_shake_js', 12 );
     }
 
@@ -336 +336 @@
     ?>
     <script type="text/javascript">
-    addLoadEvent = function(func){if(typeof jQuery!="undefined")jQuery(document).ready(func);else if(typeof wpOnload!='function'){wpOnload=func;}else{var oldonload=wpOnload;wpOnload=function(){oldonload();func();}}};
-    function s(id,pos){g(id).left=pos+'px';}
-    function g(id){return document.getElementById(id).style;}
-    function shake(id,a,d){c=a.shift();s(id,c);if(a.length>0){setTimeout(function(){shake(id,a,d);},d);}else{try{g(id).position='static';wp_attempt_focus();}catch(e){}}}
-    addLoadEvent(function(){ var p=new Array(15,30,15,0,-15,-30,-15,0);p=p.concat(p.concat(p));var i=document.forms[0].id;g(i).position='relative';shake(i,p,20);});
+    document.querySelector('form').classList.add('shake');
     </script>
     <?php