Changeset 47239 for trunk/tests/phpunit/tests/rest-api/rest-server.php

Timestamp:

02/10/2020 04:06:58 PM (5 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Add support for the REDIRECT_HTTP_AUTHORIZATION header.

Previously the REST API did not account for server configurations where the Authorization header must be added using ModRewrite. This caused major DUX issues when trying to use custom authentication mechanisms.

Fixes #47077.
Props dshanske, cklosows.

File:

• trunk/tests/phpunit/tests/rest-api/rest-server.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-server.php

@@ -1374 +1374 @@
     }
 
+    /**
+     * @ticket 47077
+     */
+    public function test_http_authorization_header_substitution() {
+        $headers        = array( 'HTTP_AUTHORIZATION' => 'foo' );
+        $parsed_headers = rest_get_server()->get_headers( $headers );
+
+        $this->assertSame(
+            array( 'AUTHORIZATION' => 'foo' ),
+            $parsed_headers
+        );
+    }
+
+    /**
+     * @ticket 47077
+     */
+    public function test_redirect_http_authorization_header_substitution() {
+        $headers        = array( 'REDIRECT_HTTP_AUTHORIZATION' => 'foo' );
+        $parsed_headers = rest_get_server()->get_headers( $headers );
+
+        $this->assertSame(
+            array( 'AUTHORIZATION' => 'foo' ),
+            $parsed_headers
+        );
+    }
+
+    /**
+     * @ticket 47077
+     */
+    public function test_redirect_http_authorization_with_http_authorization_header_substitution() {
+        $headers        = array(
+            'HTTP_AUTHORIZATION'          => 'foo',
+            'REDIRECT_HTTP_AUTHORIZATION' => 'bar',
+        );
+        $parsed_headers = rest_get_server()->get_headers( $headers );
+
+        $this->assertSame(
+            array( 'AUTHORIZATION' => 'foo' ),
+            $parsed_headers
+        );
+    }
+
+    /**
+     * @ticket 47077
+     */
+    public function test_redirect_http_authorization_with_empty_http_authorization_header_substitution() {
+        $headers        = array(
+            'HTTP_AUTHORIZATION'          => '',
+            'REDIRECT_HTTP_AUTHORIZATION' => 'bar',
+        );
+        $parsed_headers = rest_get_server()->get_headers( $headers );
+
+        $this->assertSame(
+            array( 'AUTHORIZATION' => 'bar' ),
+            $parsed_headers
+        );
+    }
+
     public function _validate_as_integer_123( $value, $request, $key ) {
         if ( ! is_int( $value ) ) {