WordPress.org

Make WordPress Core

Changeset 47247


Ignore:
Timestamp:
02/10/2020 09:13:08 PM (7 months ago)
Author:
SergeyBiryukov
Message:

Privacy: Convert buttons to links visually in Privacy Export/Erasure "Next Steps" column.

With a lot of export or erasure requests, the secondary buttons were becoming overwhelming when stacked on top of each other.

Props xkon, karmatosed.
Fixes #49323.

Location:
trunk/src/wp-admin/includes
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-privacy-data-export-requests-list-table.php

    r47246 r47247  
    100100
    101101                ?>
    102                 <span class="export-personal-data-idle"><button type="button" class="button export-personal-data-handle"><?php _e( 'Send Export Link' ); ?></button></span>
    103                 <span class="export-personal-data-processing button updating-message hidden"><?php _e( 'Sending Email...' ); ?> <span class="export-progress"></span></span>
     102                <span class="export-personal-data-idle"><button type="button" class="button-link export-personal-data-handle"><?php _e( 'Send Export Link' ); ?></button></span>
     103                <span class="export-personal-data-processing hidden"><?php _e( 'Sending Email...' ); ?> <span class="export-progress"></span></span>
    104104                <span class="export-personal-data-success success-message hidden"><?php _e( 'Email sent.' ); ?></span>
    105                 <span class="export-personal-data-failed hidden"><?php _e( 'Email could not be sent.' ); ?> <button type="button" class="button export-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
     105                <span class="export-personal-data-failed hidden"><?php _e( 'Email could not be sent.' ); ?> <button type="button" class="button-link export-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
    106106                <?php
    107107
     
    109109                break;
    110110            case 'request-failed':
    111                 submit_button( __( 'Retry' ), 'secondary', 'privacy_action_email_retry[' . $item->ID . ']', false );
     111                echo '<button type="submit" class="button-link" name="privacy_action_email_retry[' . $item->ID . ']" id="privacy_action_email_retry[' . $item->ID . ']">' . __( 'Retry' ) . '</button>';
    112112                break;
    113113            case 'request-completed':
     
    123123                        'bulk-privacy_requests'
    124124                    )
    125                 ) . '" class="button">' . esc_html__( 'Remove request' ) . '</a>';
     125                ) . '">' . esc_html__( 'Remove request' ) . '</a>';
    126126                break;
    127127        }
  • trunk/src/wp-admin/includes/class-wp-privacy-data-removal-requests-list-table.php

    r47246 r47247  
    106106
    107107                ?>
    108                 <span class="remove-personal-data-idle"><button type="button" class="button remove-personal-data-handle"><?php _e( 'Erase Personal Data' ); ?></button></span>
    109                 <span class="remove-personal-data-processing button updating-message hidden"><?php _e( 'Erasing Data...' ); ?> <span class="erasure-progress"></span></span>
     108                <span class="remove-personal-data-idle"><button type="button" class="button-link remove-personal-data-handle"><?php _e( 'Erase Personal Data' ); ?></button></span>
     109                <span class="remove-personal-data-processing hidden"><?php _e( 'Erasing Data...' ); ?> <span class="erasure-progress"></span></span>
    110110                <span class="remove-personal-data-success success-message hidden" ><?php _e( 'Erasure completed.' ); ?></span>
    111                 <span class="remove-personal-data-failed hidden"><?php _e( 'Data Erasure has failed.' ); ?> <button type="button" class="button remove-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
     111                <span class="remove-personal-data-failed hidden"><?php _e( 'Data Erasure has failed.' ); ?> <button type="button" class="button-link remove-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
    112112                <?php
    113113
     
    116116                break;
    117117            case 'request-failed':
    118                 submit_button( __( 'Retry' ), 'secondary', 'privacy_action_email_retry[' . $item->ID . ']', false );
     118                echo '<button type="submit" class="button-link" name="privacy_action_email_retry[' . $item->ID . ']" id="privacy_action_email_retry[' . $item->ID . ']">' . __( 'Retry' ) . '</button>';
    119119                break;
    120120            case 'request-completed':
     
    130130                        'bulk-privacy_requests'
    131131                    )
    132                 ) . '" class="button">' . esc_html__( 'Remove request' ) . '</a>';
     132                ) . '">' . esc_html__( 'Remove request' ) . '</a>';
    133133                break;
    134134        }
Note: See TracChangeset for help on using the changeset viewer.