Changeset 47247

Timestamp:

02/10/2020 09:13:08 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Privacy: Convert buttons to links visually in Privacy Export/Erasure "Next Steps" column.

With a lot of export or erasure requests, the secondary buttons were becoming overwhelming when stacked on top of each other.

Props xkon, karmatosed.
Fixes #49323.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-privacy-data-export-requests-list-table.php (modified) (3 diffs)
• class-wp-privacy-data-removal-requests-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-privacy-data-export-requests-list-table.php

@@ -100 +100 @@
 
                 ?>
-                <span class="export-personal-data-idle"><button type="button" class="button export-personal-data-handle"><?php _e( 'Send Export Link' ); ?></button></span>
-                <span class="export-personal-data-processing button updating-message hidden"><?php _e( 'Sending Email...' ); ?> <span class="export-progress"></span></span>
+                <span class="export-personal-data-idle"><button type="button" class="button-link export-personal-data-handle"><?php _e( 'Send Export Link' ); ?></button></span>
+                <span class="export-personal-data-processing hidden"><?php _e( 'Sending Email...' ); ?> <span class="export-progress"></span></span>
                 <span class="export-personal-data-success success-message hidden"><?php _e( 'Email sent.' ); ?></span>
-                <span class="export-personal-data-failed hidden"><?php _e( 'Email could not be sent.' ); ?> <button type="button" class="button export-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
+                <span class="export-personal-data-failed hidden"><?php _e( 'Email could not be sent.' ); ?> <button type="button" class="button-link export-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
                 <?php
 
@@ -109 +109 @@
                 break;
             case 'request-failed':
-                submit_button( __( 'Retry' ), 'secondary', 'privacy_action_email_retry[' . $item->ID . ']', false );
+                echo '<button type="submit" class="button-link" name="privacy_action_email_retry[' . $item->ID . ']" id="privacy_action_email_retry[' . $item->ID . ']">' . __( 'Retry' ) . '</button>';
                 break;
             case 'request-completed':
@@ -123 +123 @@
                         'bulk-privacy_requests'
                     )
-                ) . '" class="button">' . esc_html__( 'Remove request' ) . '</a>';
+                ) . '">' . esc_html__( 'Remove request' ) . '</a>';
                 break;
         }

trunk/src/wp-admin/includes/class-wp-privacy-data-removal-requests-list-table.php

@@ -106 +106 @@
 
                 ?>
-                <span class="remove-personal-data-idle"><button type="button" class="button remove-personal-data-handle"><?php _e( 'Erase Personal Data' ); ?></button></span>
-                <span class="remove-personal-data-processing button updating-message hidden"><?php _e( 'Erasing Data...' ); ?> <span class="erasure-progress"></span></span>
+                <span class="remove-personal-data-idle"><button type="button" class="button-link remove-personal-data-handle"><?php _e( 'Erase Personal Data' ); ?></button></span>
+                <span class="remove-personal-data-processing hidden"><?php _e( 'Erasing Data...' ); ?> <span class="erasure-progress"></span></span>
                 <span class="remove-personal-data-success success-message hidden" ><?php _e( 'Erasure completed.' ); ?></span>
-                <span class="remove-personal-data-failed hidden"><?php _e( 'Data Erasure has failed.' ); ?> <button type="button" class="button remove-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
+                <span class="remove-personal-data-failed hidden"><?php _e( 'Data Erasure has failed.' ); ?> <button type="button" class="button-link remove-personal-data-handle"><?php _e( 'Retry' ); ?></button></span>
                 <?php
 
@@ -116 +116 @@
                 break;
             case 'request-failed':
-                submit_button( __( 'Retry' ), 'secondary', 'privacy_action_email_retry[' . $item->ID . ']', false );
+                echo '<button type="submit" class="button-link" name="privacy_action_email_retry[' . $item->ID . ']" id="privacy_action_email_retry[' . $item->ID . ']">' . __( 'Retry' ) . '</button>';
                 break;
             case 'request-completed':
@@ -130 +130 @@
                         'bulk-privacy_requests'
                     )
-                ) . '" class="button">' . esc_html__( 'Remove request' ) . '</a>';
+                ) . '">' . esc_html__( 'Remove request' ) . '</a>';
                 break;
         }