Changeset 47261

Timestamp:

02/11/2020 03:37:17 AM (5 years ago)

Author:

kadamwhite

Message:

REST API: Allow meta to be set when creating a new media record via REST.

Props TimothyBlynJacobs, apermo.
Fixes #44567.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php (modified) (2 diffs)
• tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

@@ -142 +142 @@
         }
 
+        $schema = $this->get_item_schema();
+
         // Extract by name.
         $attachment_id = $insert['attachment_id'];
@@ -148 +150 @@
         if ( isset( $request['alt_text'] ) ) {
             update_post_meta( $attachment_id, '_wp_attachment_image_alt', sanitize_text_field( $request['alt_text'] ) );
+        }
+
+        if ( ! empty( $schema['properties']['meta'] ) && isset( $request['meta'] ) ) {
+            $meta_update = $this->meta->update_value( $request['meta'], $attachment_id );
+
+            if ( is_wp_error( $meta_update ) ) {
+                return $meta_update;
+            }
         }
 

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -1741 +1741 @@
     }
 
+    /**
+     * @ticket 44567
+     */
+    public function test_create_item_with_meta_values() {
+        register_post_meta(
+            'attachment',
+            'best_cannoli',
+            array(
+                'type'         => 'string',
+                'single'       => true,
+                'show_in_rest' => true,
+            )
+        );
+
+        wp_set_current_user( self::$author_id );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/media' );
+        $request->set_header( 'Content-Type', 'image/jpeg' );
+        $request->set_header( 'Content-Disposition', 'attachment; filename=cannoli.jpg' );
+        $request->set_param( 'meta', array( 'best_cannoli' => 'Chocolate-dipped, no filling' ) );
+
+        $request->set_body( file_get_contents( $this->test_file ) );
+        $response = rest_get_server()->dispatch( $request );
+        $data     = $response->get_data();
+
+        $this->assertEquals( 201, $response->get_status() );
+        $this->assertEquals( 'Chocolate-dipped, no filling', get_post_meta( $response->get_data()['id'], 'best_cannoli', true ) );
+    }
+
     public function filter_rest_insert_attachment( $attachment ) {
         self::$rest_insert_attachment_count++;