Changeset 47305

Timestamp:

02/18/2020 03:49:08 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Theme Editor: Disable CodeMirror CSS linting.

Being a good idea in theory, in practice it does not always work reliably, may not recognize newer CSS properties, and sometimes displays phantom errors with no particular error message.

A plugin can re-enable CSS linting via the wp_code_editor_settings filter.

Props skypressatx, ThemeZee, johnbillion, ianbelanger, ZanderZ, starvoters1, raoulunger, prashantvatsh, SergeyBiryukov.
Fixes #44471.

File:

• trunk/src/wp-includes/general-template.php (modified) (1 diff)

trunk/src/wp-includes/general-template.php

@@ -3722 +3722 @@
     }
 
-    if ( 'text/css' === $type ) {
-        $settings['codemirror'] = array_merge(
-            $settings['codemirror'],
-            array(
-                'mode'              => 'css',
-                'lint'              => true,
-                'autoCloseBrackets' => true,
-                'matchBrackets'     => true,
-            )
-        );
-    } elseif ( 'text/x-scss' === $type || 'text/x-less' === $type || 'text/x-sass' === $type ) {
+    if ( in_array( $type, array( 'text/css', 'text/x-scss', 'text/x-less', 'text/x-sass' ), true ) ) {
         $settings['codemirror'] = array_merge(
             $settings['codemirror'],