Changeset 47317

Timestamp:

02/19/2020 03:50:38 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Discard tags_input parameter in wp_update_post() if it's the same as existing post tags.

This ensures that wp_update_post() does not unintentionally modify post tags if the post has several tags with the same name but different slugs.

Tags should only be modified if tags_input parameter was explicitly provided, and is different from the existing tags.

Props kaggdesign, SergeyBiryukov.
Fixes #45121.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post.php (modified) (3 diffs)

trunk/src/wp-includes/post.php

@@ -4218 +4218 @@
     }
 
+    // Discard 'tags_input' parameter if it's the same as existing post tags.
+    if ( isset( $postarr['tags_input'] ) && is_object_in_taxonomy( $postarr['post_type'], 'post_tag' ) ) {
+        $tags      = get_the_terms( $postarr['ID'], 'post_tag' );
+        $tag_names = array();
+
+        if ( $tags && ! is_wp_error( $tags ) ) {
+            $tag_names = wp_list_pluck( $tags, 'name' );
+        }
+
+        if ( $postarr['tags_input'] === $tag_names ) {
+            unset( $postarr['tags_input'] );
+        }
+    }
+
     return wp_insert_post( $postarr, $wp_error );
 }

trunk/tests/phpunit/tests/post.php

@@ -1119 +1119 @@
 
     /**
-     * If a post is sticky and is updated by a user that does not have the publish_post capability, it should _stay_
-     * sticky.
+     * If a post is sticky and is updated by a user that does not have the publish_post capability,
+     * it should _stay_ sticky.
      *
      * @ticket 24153
@@ -1157 +1157 @@
 
     /**
-     * If the `edit_post()` method is invoked by a user without publish_posts permission, the sticky status of the post
-     * should not be changed.
+     * If the `edit_post()` method is invoked by a user without publish_posts permission,
+     * the sticky status of the post should not be changed.
      *
      * @ticket 24153
@@ -1427 +1427 @@
         self::assertEquals( strtotime( gmdate( 'Y-m-d H:i:s' ) ), strtotime( $post->post_date_gmt ), 'The dates should be equal', 2 );
     }
+
+    /**
+     * Test ensuring that wp_update_post() does not unintentionally modify post tags
+     * if the post has several tags with the same name but different slugs.
+     *
+     * Tags should only be modified if 'tags_input' parameter was explicitly provided,
+     * and is different from the existing tags.
+     *
+     * @ticket 45121
+     */
+    public function test_update_post_should_only_modify_post_tags_if_different_tags_input_was_provided() {
+        $tag_1 = wp_insert_term( 'wp_update_post_tag', 'post_tag', array( 'slug' => 'wp_update_post_tag_1' ) );
+        $tag_2 = wp_insert_term( 'wp_update_post_tag', 'post_tag', array( 'slug' => 'wp_update_post_tag_2' ) );
+        $tag_3 = wp_insert_term( 'wp_update_post_tag', 'post_tag', array( 'slug' => 'wp_update_post_tag_3' ) );
+
+        $post_id = self::factory()->post->create(
+            array(
+                'tags_input' => array( $tag_1['term_id'], $tag_2['term_id'] ),
+            )
+        );
+
+        $post = get_post( $post_id );
+
+        $tags = wp_get_post_tags( $post->ID, array( 'fields' => 'ids' ) );
+        $this->assertEqualSets( array( $tag_1['term_id'], $tag_2['term_id'] ), $tags );
+
+        wp_update_post( $post );
+
+        $tags = wp_get_post_tags( $post->ID, array( 'fields' => 'ids' ) );
+        $this->assertEqualSets( array( $tag_1['term_id'], $tag_2['term_id'] ), $tags );
+
+        wp_update_post(
+            array(
+                'ID'         => $post->ID,
+                'tags_input' => array( $tag_2['term_id'], $tag_3['term_id'] ),
+            )
+        );
+
+        $tags = wp_get_post_tags( $post->ID, array( 'fields' => 'ids' ) );
+        $this->assertEqualSets( array( $tag_2['term_id'], $tag_3['term_id'] ), $tags );
+    }
 }