Changeset 47317 for trunk/src/wp-includes/post.php

Timestamp:

02/19/2020 03:50:38 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Discard tags_input parameter in wp_update_post() if it's the same as existing post tags.

This ensures that wp_update_post() does not unintentionally modify post tags if the post has several tags with the same name but different slugs.

Tags should only be modified if tags_input parameter was explicitly provided, and is different from the existing tags.

Props kaggdesign, SergeyBiryukov.
Fixes #45121.

File:

• trunk/src/wp-includes/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -4218 +4218 @@
     }
 
+    // Discard 'tags_input' parameter if it's the same as existing post tags.
+    if ( isset( $postarr['tags_input'] ) && is_object_in_taxonomy( $postarr['post_type'], 'post_tag' ) ) {
+        $tags      = get_the_terms( $postarr['ID'], 'post_tag' );
+        $tag_names = array();
+
+        if ( $tags && ! is_wp_error( $tags ) ) {
+            $tag_names = wp_list_pluck( $tags, 'name' );
+        }
+
+        if ( $postarr['tags_input'] === $tag_names ) {
+            unset( $postarr['tags_input'] );
+        }
+    }
+
     return wp_insert_post( $postarr, $wp_error );
 }