Changeset 47328 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

Timestamp:

02/20/2020 04:56:17 PM (5 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Don't assume all item schemas have properties.

All schema types, not just objects, are permitted as the base type of a resource. A future patch could add validation support for those types, but this fix only prevents a PHP warning from being issued.

Props dhavalkasvala, johnwatkins0, birgire.
Fixes #48785.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

@@ -345 +345 @@
         $schema = $this->get_item_schema();
 
-        foreach ( $schema['properties'] as &$property ) {
-            unset( $property['arg_options'] );
+        if ( ! empty( $schema['properties'] ) ) {
+            foreach ( $schema['properties'] as &$property ) {
+                unset( $property['arg_options'] );
+            }
         }