Changeset 47338 for branches/3.8/tests/phpunit/tests/media.php

Timestamp:

02/21/2020 01:05:39 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Build/Test Tools: Fix the Travis CI build for the 3.8 branch.

Among other fixes, this backports [26871], [26909-26910], [26940], [27086], [27168], [28799], [28873], [28943], [28961], [28964], [28966-28967], [29120], [29251], [29503], [29860], [29869], [29954], [30001], [30160], [30282], [30285], [30289-30291], [30513-30514], [30516-30521], [30524], [30526], [30529-30530], [31253-31254], [31257-31259], [31622], [40241], [40255], [40257], [40259], [40269], [40271], [40446], [40449], [40457], [40604], [40538], [40833], [41082], [41303], [41306], [44993].

See #49485.

Location:

branches/3.8

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/media.php (modified) (2 diffs)

branches/3.8/tests/phpunit/tests/media.php

@@ -367 +367 @@
         );
 
-        $post_id = media_handle_upload( 'upload', 0, array(), array( 'action' => 'test_upload_titles', 'test_form' => false ) );
+        $post_id = media_handle_upload(
+            'upload',
+            0,
+            array(),
+            array(
+                'action'               => 'test_upload_titles',
+                'test_form'            => false,
+                /*
+                 * This test previously failed on WP < 4.0 due to is_uploaded_file()
+                 * and move_uploaded_file() usage in wp_handle_upload().
+                 *
+                 * Since successful upload is irrelevant for the purpose of this test,
+                 * discarding upload errors allows the test to proceed.
+                 */
+                'upload_error_handler' => array( $this, '_discard_upload_errors' ),
+            )
+        );
 
         unset( $_FILES['upload'] );
@@ -377 +393 @@
 
         $this->assertEquals( 'This is a test', $post->post_title );
+    }
+
+    function _discard_upload_errors( &$file, $message ) {
+        $uploads  = wp_upload_dir();
+        $filename = wp_unique_filename( $uploads['path'], $file['name'] );
+
+        $new_file = $uploads['path'] . "/$filename";
+        $url      = $uploads['url'] . "/$filename";
+
+        return array( 'file' => $new_file, 'url' => $url, 'type' => $file['type'] );
     }