Changeset 47349

Timestamp:

02/23/2020 08:56:44 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Add missing braces to if conditions and use strict comparison in js/_enqueues/wp/media/editor.js.

Props ankitmaru.
Fixes #49317.

File:

• trunk/src/js/_enqueues/wp/media/editor.js (modified) (5 diffs)

trunk/src/js/_enqueues/wp/media/editor.js

@@ -165 +165 @@
 
             props = wp.media.string.props( props, attachment );
-            if ( props.link !== 'embed' )
+            if ( props.link !== 'embed' ) {
                 return wp.media.string.link( props );
+            }
 
             shortcode = {};
@@ -447 +448 @@
                 if ( attrs._orderbyRandom ) {
                     attrs.orderby = 'rand';
-                } else if ( attrs._orderByField && attrs._orderByField != 'rand' ) {
+                } else if ( attrs._orderByField && 'rand' !== attrs._orderByField ) {
                     attrs.orderby = attrs._orderByField;
                 }
@@ -626 +627 @@
                 _wpnonce:     settings.post.nonce
             }).done( function( html ) {
-                if ( html == '0' ) {
+                if ( '0' === html ) {
                     window.alert( window.setPostThumbnailL10n.error );
                     return;
@@ -802 +803 @@
                 selection = selection || state.get('selection');
 
-                if ( ! selection )
+                if ( ! selection ) {
                     return;
+                }
 
                 $.when.apply( $, selection.map( function( attachment ) {
@@ -966 +968 @@
                         alt:   'image_alt'
                     }, function( option, prop ) {
-                        if ( props[ prop ] )
+                        if ( props[ prop ] ) {
                             options[ option ] = props[ prop ];
+                        }
                     });
                 } else if ( 'video' === attachment.type ) {