Changeset 47355

Timestamp:

02/25/2020 12:57:33 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Script Loader: Remove unnecessary reference sign from function definitions in script loader.

This resolves PHP warnings when extensions like php_uopz or php_tideways_xhprof are in use.

Object variables in PHP 5+ contain a reference to the object, and it's the reference that's passed around.

Props jqz, killerbishop, Mte90, TJNowell, jorbin, pento, pcarvalho, valentinbora, SergeyBiryukov.
Fixes #44979.

File:

• trunk/src/wp-includes/script-loader.php (modified) (8 diffs)

trunk/src/wp-includes/script-loader.php

@@ -42 +42 @@
  * @param WP_Scripts $scripts WP_Scripts object.
  */
-function wp_register_tinymce_scripts( &$scripts, $force_uncompressed = false ) {
+function wp_register_tinymce_scripts( $scripts, $force_uncompressed = false ) {
     global $tinymce_version, $concatenate_scripts, $compress_scripts;
     $suffix     = wp_scripts_get_suffix();
@@ -74 +74 @@
  * @param WP_Scripts $scripts WP_Scripts object.
  */
-function wp_default_packages_vendor( &$scripts ) {
+function wp_default_packages_vendor( $scripts ) {
     global $wp_locale;
 
@@ -177 +177 @@
  * @return string Conditional polyfill inline script.
  */
-function wp_get_script_polyfill( &$scripts, $tests ) {
+function wp_get_script_polyfill( $scripts, $tests ) {
     $polyfill = '';
     foreach ( $tests as $test => $handle ) {
@@ -229 +229 @@
  * @param WP_Scripts $scripts WP_Scripts object.
  */
-function wp_default_packages_scripts( &$scripts ) {
+function wp_default_packages_scripts( $scripts ) {
     $suffix = wp_scripts_get_suffix();
 
@@ -274 +274 @@
  * @param WP_Scripts $scripts WP_Scripts object.
  */
-function wp_default_packages_inline_scripts( &$scripts ) {
+function wp_default_packages_inline_scripts( $scripts ) {
     global $wp_locale;
 
@@ -522 +522 @@
  * @param WP_Scripts $scripts WP_Scripts object.
  */
-function wp_default_packages( &$scripts ) {
+function wp_default_packages( $scripts ) {
     wp_default_packages_vendor( $scripts );
     wp_register_tinymce_scripts( $scripts );
@@ -581 +581 @@
  * @param WP_Scripts $scripts WP_Scripts object.
  */
-function wp_default_scripts( &$scripts ) {
+function wp_default_scripts( $scripts ) {
     $suffix     = wp_scripts_get_suffix();
     $dev_suffix = wp_scripts_get_suffix( 'dev' );
@@ -1616 +1616 @@
  * @param WP_Styles $styles
  */
-function wp_default_styles( &$styles ) {
+function wp_default_styles( $styles ) {
     // Include an unmodified $wp_version.
     require ABSPATH . WPINC . '/version.php';