Changeset 47366 for trunk/tests/phpunit/tests/comment/template.php

Timestamp:

02/25/2020 05:32:34 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Comments: Restore the fourth parameter of comments_number() as $post_id, for consistency with get_comments_number_text().

The parameter was previously used as the number of comments, marked as deprecated in [5101].

Given that it's been deprecated for the last 13 years, it should be safe to undeprecate and repurpose it for a cleaner function signature, instead of adding a fifth parameter.

Follow-up to [47276].

Fixes #48772.

File:

• trunk/tests/phpunit/tests/comment/template.php (modified) (1 diff)

trunk/tests/phpunit/tests/comment/template.php

@@ -41 +41 @@
 
         $this->assertEquals( sprintf( _n( '%s Comment', '%s Comments', 6 ), '6' ), $comments_number_text );
+
+        ob_start();
+        comments_number( false, false, false, $post_id );
+        $comments_number_text = ob_get_clean();
+
+        $this->assertEquals( sprintf( _n( '%s Comment', '%s Comments', 6 ), '6' ), $comments_number_text );
+
     }