Changeset 47370 for trunk/src/wp-includes/load.php

Timestamp:

02/25/2020 06:31:33 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Bootstrap/Load: In wp_magic_quotes(), revert the type change to string for REQUEST_TIME and REQUEST_TIME_FLOAT values, which should retain their proper type.

Among other things, this preserves compatibility of WP with PHPUnit Code Coverage generation.

Props jrf, Veraxus, Rarst.
See #48605.

File:

• trunk/src/wp-includes/load.php (modified) (1 diff)

trunk/src/wp-includes/load.php

@@ -930 +930 @@
         $_SERVER = add_magic_quotes( $_SERVER );
 
+        /*
+         * Revert the type change to string for two indexes which should retain their proper type.
+         * Among other things, this preserves compatibility of WP with PHPUnit Code Coverage generation.
+         */
+        if ( isset( $_SERVER['REQUEST_TIME'] ) ) {
+                $_SERVER['REQUEST_TIME'] = (int) $_SERVER['REQUEST_TIME'];
+        }
+
+        if ( isset( $_SERVER['REQUEST_TIME_FLOAT'] ) ) {
+                $_SERVER['REQUEST_TIME_FLOAT'] = (float) $_SERVER['REQUEST_TIME_FLOAT'];
+        }
+
         // Force REQUEST to be GET + POST.
         $_REQUEST = array_merge( $_GET, $_POST );