Changeset 47371

Timestamp:

02/25/2020 07:27:22 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Widgets: Create a unique HTML ID for the <ul> element of Recent Comments widget if more than one instance is displayed on the page.

Props peterwilsoncc, audrasjb, birgire, justinahinon, mbrailer, desrosj.
Fixes #46747.

Location:

trunk/src/wp-includes/widgets

Files:

• class-wp-widget-categories.php (modified) (1 diff)
• class-wp-widget-recent-comments.php (modified) (3 diffs)

trunk/src/wp-includes/widgets/class-wp-widget-categories.php

@@ -35 +35 @@
          *
          * @since 2.8.0
+         * @since 4.2.0 Creates a unique HTML ID for the `<select>` element
+         *              if more than one instance is displayed on the page.
          *
          * @staticvar bool $first_dropdown

trunk/src/wp-includes/widgets/class-wp-widget-recent-comments.php

@@ -67 +67 @@
          *
          * @since 2.8.0
+         * @since 5.4.0 Creates a unique HTML ID for the `<ul>` element
+         *              if more than one instance is displayed on the page.
+         *
+         * @staticvar bool $first_instance
          *
          * @param array $args     Display arguments including 'before_title', 'after_title',
@@ -73 +77 @@
          */
         public function widget( $args, $instance ) {
+                static $first_instance = true;
+
                 if ( ! isset( $args['widget_id'] ) ) {
                         $args['widget_id'] = $this->id;
@@ -117 +123 @@
                 }
 
-                $output .= '<ul id="recentcomments">';
+                $recent_comments_id = ( $first_instance ) ? 'recentcomments' : "recentcomments-{$this->number}";
+                $first_instance     = false;
+
+                $output .= '<ul id="' . esc_attr( $recent_comments_id ) . '">';
                 if ( is_array( $comments ) && $comments ) {
                         // Prime cache for associated posts. (Prime post term cache if we need it for permalinks.)