Changeset 47372

Timestamp:

02/25/2020 07:33:22 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison for normalize_whitespace() checks when comparing revisions or autosaves.

Props dkarfa, itowhid06, TimothyBlynJacobs.
Fixes #47965.

Location:

trunk/src

Files:

• wp-admin/edit-form-advanced.php (modified) (1 diff)
• wp-admin/includes/post.php (modified) (1 diff)
• wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php (modified) (1 diff)
• wp-includes/revision.php (modified) (1 diff)

trunk/src/wp-admin/edit-form-advanced.php

@@ -246 +246 @@
 if ( $autosave && mysql2date( 'U', $autosave->post_modified_gmt, false ) > mysql2date( 'U', $post->post_modified_gmt, false ) ) {
     foreach ( _wp_post_revision_fields( $post ) as $autosave_field => $_autosave_field ) {
-        if ( normalize_whitespace( $autosave->$autosave_field ) != normalize_whitespace( $post->$autosave_field ) ) {
+        if ( normalize_whitespace( $autosave->$autosave_field ) !== normalize_whitespace( $post->$autosave_field ) ) {
             $notice = sprintf(
                 /* translators: %s: URL to view the autosave. */

trunk/src/wp-admin/includes/post.php

@@ -1830 +1830 @@
         $autosave_is_different = false;
         foreach ( array_intersect( array_keys( $new_autosave ), array_keys( _wp_post_revision_fields( $post ) ) ) as $field ) {
-            if ( normalize_whitespace( $new_autosave[ $field ] ) != normalize_whitespace( $post->$field ) ) {
+            if ( normalize_whitespace( $new_autosave[ $field ] ) !== normalize_whitespace( $post->$field ) ) {
                 $autosave_is_different = true;
                 break;

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php

@@ -369 +369 @@
 
             foreach ( array_intersect( array_keys( $new_autosave ), array_keys( _wp_post_revision_fields( $post ) ) ) as $field ) {
-                if ( normalize_whitespace( $new_autosave[ $field ] ) != normalize_whitespace( $post->$field ) ) {
+                if ( normalize_whitespace( $new_autosave[ $field ] ) !== normalize_whitespace( $post->$field ) ) {
                     $autosave_is_different = true;
                     break;

trunk/src/wp-includes/revision.php

@@ -163 +163 @@
 
             foreach ( array_keys( _wp_post_revision_fields( $post ) ) as $field ) {
-                if ( normalize_whitespace( $post->$field ) != normalize_whitespace( $last_revision->$field ) ) {
+                if ( normalize_whitespace( $post->$field ) !== normalize_whitespace( $last_revision->$field ) ) {
                     $post_has_changed = true;
                     break;